B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] how to compile the latest version of batctl in OpenWrt 12.09
by liu 15 Aug '14

15 Aug '14

Hello, I try to test the latest version of batman-adv in OpenWrt 12.09. I failed to compile 'batctl' because of the old version of 'libnl' in OpenWrt.The version '2014.3' and the development version of 'batctl' require 'libnl-3.0', but OpenWrt 12.09 only contain the 'libnl-2.0.1'. That's the problem. How to fix this? Anyone have built it in OpenWrt 12.09 yet? Thanks. Best regards liu

2 3

[B.A.T.M.A.N.] Testing example of interface bonding
by Ray Gibson 13 Aug '14

13 Aug '14

Hello, Are there any documented cases (aside from the aging graph on the wiki) on batman-adv bonding setups? I'm testing batman-adv 2014.3.0 in an effort to experiment and test with multi-link optimizations. There is no wifi in the picture at the moment, this is being done with tap interfaces right now. My two nodes have this network config: lan0: bridge of eth0 and bat0, 192.168.100.1 on node1, 192.168.100.2 on node2 bat0: includes tap0 and tap1 active, no IP. eth1: "wan" link, 10.10.10.1 on node1, 10.10.10.2 on node2 tap0/1: openvpn bridge links over eth1, no IPs assigned to these interfaces. This is a VMware environment for testing. With the above setup, I can ping/iperf/whatever back and forth on the 192.168.100.x network. It works great just extending a lan transparently on a wan link. This was the original idea, with redundant connections (hence the multi tap interfaces). Now, I'm trying to isolate the test down to bonding. However, enabling bonding in batctl on both nodes has no apparent effect whatsoever. Watching an iperf session in ifstat, I will see constant traffic on bat0, and then either tap0 or tap1 depending on how it's feeling at the time. Sometimes it will shift all the traffic to the other tap interface. Sometimes the incoming traffic will be on one interface and the outgoing traffic will be on the other. Note: I'm running iperf/etc on the nodes themselves, not on separate devices on the lan bridge. Ultimately I am looking to try bonding several 3G or 4G devices together with batman-adv to achieve higher throughput to a single destination. Thank you for any comments or suggestions. I find batman-adv very useful in other projects and look to extend its use into this one. Ray

2 3

[B.A.T.M.A.N.] [RFC] batman-adv: experimental sysfs variable to always apply half duplex penalty
by Simon Wunderlich 13 Aug '14

13 Aug '14

The half duplex interface penalty is currently only applied for wifi interfaces. While this is intended, the bonding feature relies on different next hop routers to be chosen for different interface tables, which does not necessarily happen for Ethernet or virtual machine networks when all links considered equally perfect and are not penalized. This patch adds an option to always apply the half duplex interface penalty, regardless of whether its an wifi interface or not. Then, the Ethernet interfaces are also penalized and the bonding has enough candidates to choose from. I'm not yet sure if its a good idea to add that option, and it should probably go into debugfs anyway, but adding it in sysfs for now was the easiest option. :) In any way, I'd like to hear about your opinion and/or test results! Thanks, Simon Reported-by: Ray Gibson <booray(a)gmail.com> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> --- bat_iv_ogm.c | 3 ++- sysfs.c | 3 +++ types.h | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index 73209f3..46ac297 100644 --- a/bat_iv_ogm.c +++ b/bat_iv_ogm.c @@ -1227,7 +1227,8 @@ static int batadv_iv_ogm_calc_tq(struct batadv_orig_node *orig_node, */ tq_iface_penalty = BATADV_TQ_MAX_VALUE; if (if_outgoing && (if_incoming == if_outgoing) && - batadv_is_wifi_netdev(if_outgoing->net_dev)) + (batadv_is_wifi_netdev(if_outgoing->net_dev) || + atomic_read(&bat_priv->always_half_duplex_penalty))) tq_iface_penalty = batadv_hop_penalty(BATADV_TQ_MAX_VALUE, bat_priv); diff --git a/sysfs.c b/sysfs.c index fc47baa..3fca470 100644 --- a/sysfs.c +++ b/sysfs.c @@ -545,6 +545,8 @@ BATADV_ATTR_SIF_UINT(orig_interval, S_IRUGO | S_IWUSR, 2 * BATADV_JITTER, INT_MAX, NULL); BATADV_ATTR_SIF_UINT(hop_penalty, S_IRUGO | S_IWUSR, 0, BATADV_TQ_MAX_VALUE, NULL); +BATADV_ATTR_SIF_BOOL(always_half_duplex_penalty, S_IRUGO | S_IWUSR, NULL); + BATADV_ATTR_SIF_UINT(gw_sel_class, S_IRUGO | S_IWUSR, 1, BATADV_TQ_MAX_VALUE, batadv_post_gw_reselect); static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, @@ -579,6 +581,7 @@ static struct batadv_attribute *batadv_mesh_attrs[] = { &batadv_attr_gw_mode, &batadv_attr_orig_interval, &batadv_attr_hop_penalty, + &batadv_attr_always_half_duplex_penalty, &batadv_attr_gw_sel_class, &batadv_attr_gw_bandwidth, #ifdef CONFIG_BATMAN_ADV_DEBUG diff --git a/types.h b/types.h index 462a70c..cb75fac 100644 --- a/types.h +++ b/types.h @@ -727,6 +727,7 @@ struct batadv_softif_vlan { * @gw_sel_class: gateway selection class (applies if gw_mode client) * @orig_interval: OGM broadcast interval in milliseconds * @hop_penalty: penalty which will be applied to an OGM's tq-field on every hop + * @always_half_duplex_penalty: whether to always apply half duplex penalty * @log_level: configured log level (see batadv_dbg_level) * @bcast_seqno: last sent broadcast packet sequence number * @bcast_queue_left: number of remaining buffered broadcast packet slots @@ -780,6 +781,7 @@ struct batadv_priv { atomic_t gw_sel_class; atomic_t orig_interval; atomic_t hop_penalty; + atomic_t always_half_duplex_penalty; #ifdef CONFIG_BATMAN_ADV_DEBUG atomic_t log_level; #endif -- 2.1.0.rc1

1 0

[B.A.T.M.A.N.] [PATCHv7 0/3] Multicast optimizations for bridges
by Linus Lüssing 11 Aug '14

11 Aug '14

This patchset enables the usage of the batman-adv multicast optimizations for scenarios involving bridges on top of e.g. bat0, too. Along come two more patches adding according debugging facilities to make it possible for the user to check why the multicast optimizations might not work ideally to give hints about what they might change about their topology. Cheers, Linus Changes in v7 (thanks to Simon's suggestions): - PATCH 2/3: * renaming old/new_querier to old/new_state * slightly extended kerneldoc of batadv_mcast_querier_log() * removing words "good" and "bad" from debug output * simplified batadv_mcast_flags_log() * assignment instead of memset in batadv_mcast_mla_tvlv_update() and batadv_softif_init_late() * simple struct member assignments instead of one complex struct assigment * removing unnecessary memcmp's * substituting return statement for an if-block in batadv_mcast_querier_log() and batadv_mcast_bridge_log() * print "Unsnoopables(U)-flag" instead of just "U-flag" - PATCH 3/3: * use bat_priv values instead of querying bridge ABI in batadv_mcast_flags_print_header() Changes in v6: * New PATCH 2/3 inserted, moving logging to separate patch * More verbose logging added to PATCH 2/3: Bridge and querier state changes are logged too * upper case to lower case for kernel doc of batadv_mcast_flags_open (PATCH 2/3) * Adding note to kernel doc of batadv_mcast_get_bridge about increased refcount (PATCH 1/3) * Printing some lines about current bridge and querier state to debugfs too (PATCH 3/3) Changes in v5 (PATCH 2/2 only): * s/dat_cache/mcast_flags/ in kerneldoc (copy&paste error) Changes in v4 (PATCH 2/2 only): * initial {ad,e}dition of this patch Changes in v3 (PATCH 1/2 only): * Removed "RFC" tag in title again: The stubs and new export are upstream in net-next and therefore going to be included in 3.17 * Added some debug output: * Two warning messages: -> Old kernel version or no bridge IGMP/MLD snooping compiled * New batman-adv log-level "mcast": -> Logging mcast flag changes (a third debugging facility, a new table for debugfs for a global mcast flag overview will be added in a separate patch later as discussed with Simon) Changes in v2 (PATCH 1/2 only): * fetching local (= on this same kernel) multicast listeners from the bridge instead of the bat0 interface if a bridge is present - just like ip addresses and routes should be used from br0, the same goes for multicast listeners * beautification of batadv_mcast_mla_br_addr_cpy(), now using already present functions from the kernel instead of own, hackish approach * changed names of some goto-labels (not using "skip" anymore) * using new, third bridge multicast export (because this export is not upstream yet, I've added the "RFC" in the title): br_multicast_has_querier_anywhere() * adding compat stubs for two bridge multicast exports, to make batman-adv compile- and usable even if a 3.16 kernel was compiled without bridge code - the stubs are supposed to be upstream in the bridge code in 3.17 (therefore just 'compat') * updated kerneldocs for batadv_mcast_mla_bridge_get() and batadv_mcast_mla_softif_get() * The two sentences in the commit message starting with "Queriers: ..." were slightly modified to include the third bridge multicast export

2 4

[B.A.T.M.A.N.] [PATCHv2 01/13] batman-adv: kernel doc fixes for bat_iv_ogm.c
by Martin Hundebøll 11 Aug '14

11 Aug '14

Signed-off-by: Martin Hundebøll <martin(a)hundeboll.net> --- bat_iv_ogm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index 1e80539..73209f3 100644 --- a/bat_iv_ogm.c +++ b/bat_iv_ogm.c @@ -28,7 +28,7 @@ /** - * batadv_dup_status - duplicate status + * enum batadv_dup_status - duplicate status * @BATADV_NO_DUP: the packet is a duplicate * @BATADV_ORIG_DUP: OGM is a duplicate in the originator (but not for the * neighbor) @@ -517,7 +517,7 @@ out: * @bat_priv: the bat priv with all the soft interface information * @packet_len: (total) length of the OGM * @send_time: timestamp (jiffies) when the packet is to be sent - * @direktlink: true if this is a direct link packet + * @directlink: true if this is a direct link packet * @if_incoming: interface where the packet was received * @if_outgoing: interface for which the retransmission should be considered * @forw_packet: the forwarded packet which should be checked @@ -1366,6 +1366,7 @@ out: /** * batadv_iv_ogm_process_per_outif - process a batman iv OGM for an outgoing if * @skb: the skb containing the OGM + * @ogm_offset: offset from skb->data to start of ogm header * @orig_node: the (cached) orig node for the originator of this OGM * @if_incoming: the interface where this packet was received * @if_outgoing: the interface for which the packet should be considered @@ -1902,10 +1903,10 @@ out: * batadv_iv_ogm_neigh_is_eob - check if neigh1 is equally good or better than * neigh2 from the metric prospective * @neigh1: the first neighbor object of the comparison - * @if_outgoing: outgoing interface for the first neighbor + * @if_outgoing1: outgoing interface for the first neighbor * @neigh2: the second neighbor object of the comparison * @if_outgoing2: outgoing interface for the second neighbor - + * * Returns true if the metric via neigh1 is equally good or better than * the metric via neigh2, false otherwise. */ -- 2.0.1

3 20

[B.A.T.M.A.N.] [PATCH] batman-adv: remove obsolete variable primary_iface from orig_node
by Simon Wunderlich 11 Aug '14

11 Aug '14

This variable became obsolete when changing to the new bonding mechanism based on the multi interface optimization. Since its not used anywhere, remove it. Reported-by: Linus Lüssing <linus.luessing(a)web.de> Signed-off-by: Simon Wunderlich <sw(a)simonwunderlich.de> --- types.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/types.h b/types.h index 8854c05..462a70c 100644 --- a/types.h +++ b/types.h @@ -199,7 +199,6 @@ struct batadv_orig_bat_iv { /** * struct batadv_orig_node - structure for orig_list maintaining nodes of mesh * @orig: originator ethernet address - * @primary_addr: hosts primary interface address * @ifinfo_list: list for routers per outgoing interface * @last_bonding_candidate: pointer to last ifinfo of last used router * @batadv_dat_addr_t: address of the orig node in the distributed hash @@ -244,7 +243,6 @@ struct batadv_orig_bat_iv { */ struct batadv_orig_node { uint8_t orig[ETH_ALEN]; - uint8_t primary_addr[ETH_ALEN]; struct hlist_head ifinfo_list; struct batadv_orig_ifinfo *last_bonding_candidate; #ifdef CONFIG_BATMAN_ADV_DAT -- 1.9.1

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: avoid useless return in void functions
by Antonio Quartulli 11 Aug '14

11 Aug '14

Cc: Linus Lüssing <linus.luessing(a)web.de> Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- multicast.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/multicast.h b/multicast.h index 73b5d45..3a44ebd 100644 --- a/multicast.h +++ b/multicast.h @@ -50,7 +50,6 @@ void batadv_mcast_purge_orig(struct batadv_orig_node *orig_node); static inline void batadv_mcast_mla_update(struct batadv_priv *bat_priv) { - return; } static inline enum batadv_forw_mode @@ -67,12 +66,10 @@ static inline int batadv_mcast_init(struct batadv_priv *bat_priv) static inline void batadv_mcast_free(struct batadv_priv *bat_priv) { - return; } static inline void batadv_mcast_purge_orig(struct batadv_orig_node *orig_node) { - return; } #endif /* CONFIG_BATMAN_ADV_MCAST */ -- 1.8.5.5

2 1

[B.A.T.M.A.N.] [PATCH] batctl: Don't use hyphen for parameter in manpage
by Sven Eckelmann 11 Aug '14

11 Aug '14

By default, "-" chars are interpreted as hyphens (U+2010) by groff, not as minus signs (U+002D). Since options to programs use minus signs (U+002D), this means for example in UTF-8 locales that you cannot cut and paste options, nor search for them easily. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- man/batctl.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/batctl.8 b/man/batctl.8 index 110020e..bbe888c 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -61,7 +61,7 @@ originator interval. The interval is in units of milliseconds. .br .IP "\fBap_isolation\fP|\fBap\fP [\fB0\fP|\fB1\fP]" If no parameter is given the current ap isolation setting is displayed. Otherwise the parameter is used to enable or -disable ap isolation. This command can be used in conjunction with "-m" option to target per VLAN configurations. +disable ap isolation. This command can be used in conjunction with "\-m" option to target per VLAN configurations. .br .IP "\fBbridge_loop_avoidance\fP|\fBbl\fP [\fB0\fP|\fB1\fP]" If no parameter is given the current bridge loop avoidance setting is displayed. Otherwise the parameter is used to enable -- 2.0.1

2 1

[B.A.T.M.A.N.] [PATCH] batctl: fix backbone address in tcpdump for bla request frames
by Simon Wunderlich 11 Aug '14

11 Aug '14

From: Simon Wunderlich <simon(a)open-mesh.com> hw_src just contains another copy of the destination. The backbone sending the request is setting its mac address into Ethernet source, so print that instead. For reference, see the documentation: http://www.open-mesh.org/projects/batman-adv/wiki/Bridge-loop-avoidance-Pro… Signed-off-by: Simon Wunderlich <simon(a)open-mesh.com> --- tcpdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcpdump.c b/tcpdump.c index e84617e..ada8938 100644 --- a/tcpdump.c +++ b/tcpdump.c @@ -148,7 +148,7 @@ static int dump_bla2_claim(struct ether_header *eth_hdr, break; case BATADV_CLAIM_TYPE_REQUEST: printf("BLA REQUEST, src backbone %s, ", - get_name_by_macaddr((struct ether_addr *)hw_src, read_opt)); + get_name_by_macaddr((struct ether_addr *)eth_hdr->ether_shost, read_opt)); printf("dst backbone %s\n", get_name_by_macaddr((struct ether_addr *)eth_hdr->ether_dhost, read_opt)); break; -- 1.9.1

2 1

[B.A.T.M.A.N.] how to make IP layer handle the change of network topology
by liudows 08 Aug '14

08 Aug '14

Hello, eveyone, I am learning the batman.adv recently. We know that batman.adv works on layer 2. When the network topology change, batman.adv can know this change and handle it. But the IP layer doesn't know that. How to make IP layer handle the change of network topology? For example, I have 3 mesh nodes, client node A, gateway node B and geteway node C. A connects to internet via B. Then I shutdown B. I guess A will switch to C as it's gateway node automatically. But it's not so. A continuously send the ARP request packet to search the MAC address of B. The default gateway is still B, not C. So, how should I do to make the IP layer be aware of that the gateway has swithed to another one? Thanks! Best regards. liu

4 6

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N