B.A.T.M.A.N August 2022

b.a.t.m.a.n@lists.open-mesh.org

3 participants
5 discussions

by Charles Chien

Hello developers, We’re currently trying to install batman-adv on an ARM platform but we ran into some issues and we would appreciate your help to answer our questions below: Is the batman-adv module compatible with an ARM processor (Raspberry PI 4)? I’m trying to install batman-adv onto an ARM Raspberry PI 4 with a Debian based Linux distribution (Pop OS). However, when I run “modprobe batman-adv”, it returns a FATAL error complaining that the module is not found in the “/lib/modules” directory. Where can I find/download the “.ko” for batman-adv for the ARM platform? And if I need to recompile the .ko file for ARM, is there an online repository where I can find the original source code for the batman-adv driver? -- Regards, Charles

4 months, 3 weeks

[PATCH] batman-adv: Fix hang up with small MTU hard-interface

by Shigeru Yoshida

The system hangs up when batman-adv soft-interface is created on hard-interface with small MTU. For example, the following commands create batman-adv soft-interface on dummy interface with zero MTU: # ip link add name dummy0 type dummy # ip link set mtu 0 dev dummy0 # ip link set up dev dummy0 # ip link add name bat0 type batadv # ip link set dev dummy0 master bat0 These commands cause the system hang up with the following messages: [ 90.578925][ T6689] batman_adv: bat0: Adding interface: dummy0 [ 90.580884][ T6689] batman_adv: bat0: The MTU of interface dummy0 is too small (0) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem. [ 90.586264][ T6689] batman_adv: bat0: Interface activated: dummy0 [ 90.590061][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) [ 90.595517][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) [ 90.598499][ T6689] batman_adv: bat0: Forced to purge local tt entries to fit new maximum fragment MTU (-320) This patch fixes this issue by returning error when enabling hard-interface with small MTU size. Signed-off-by: Shigeru Yoshida <syoshida(a)redhat.com> --- net/batman-adv/hard-interface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c index b8f8da7ee3de..dce5557800e9 100644 --- a/net/batman-adv/hard-interface.c +++ b/net/batman-adv/hard-interface.c @@ -700,6 +700,9 @@ int batadv_hardif_enable_interface(struct batadv_hard_iface *hard_iface, int max_header_len = batadv_max_header_len(); int ret; + if (hard_iface->net_dev->mtu < ETH_MIN_MTU + max_header_len) + return -EINVAL; + if (hard_iface->if_status != BATADV_IF_NOT_IN_USE) goto out; -- 2.37.2

6 months, 3 weeks

[PATCH 5.19 1114/1157] batman-adv: tracing: Use the new __vstring() helper

by Greg Kroah-Hartman

From: Steven Rostedt (Google) <rostedt(a)goodmis.org> [ Upstream commit 9abc291812d784bd4a26c01af4ebdbf9f2dbf0bb ] Instead of open coding a __dynamic_array() with a fixed length (which defeats the purpose of the dynamic array in the first place). Use the new __vstring() helper that will use a va_list and only write enough of the string into the ring buffer that is needed. Link: https://lkml.kernel.org/r/20220724191650.236b1355@rorschach.local.home Cc: Marek Lindner <mareklindner(a)neomailbox.ch> Cc: Ingo Molnar <mingo(a)kernel.org> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Simon Wunderlich <sw(a)simonwunderlich.de> Cc: Antonio Quartulli <a(a)unstable.cc> Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Eric Dumazet <edumazet(a)google.com> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Paolo Abeni <pabeni(a)redhat.com> Cc: b.a.t.m.a.n(a)lists.open-mesh.org Cc: netdev(a)vger.kernel.org Acked-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Steven Rostedt (Google) <rostedt(a)goodmis.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- net/batman-adv/trace.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/net/batman-adv/trace.h b/net/batman-adv/trace.h index d673ebdd0426..31c8f922651d 100644 --- a/net/batman-adv/trace.h +++ b/net/batman-adv/trace.h @@ -28,8 +28,6 @@ #endif /* CONFIG_BATMAN_ADV_TRACING */ -#define BATADV_MAX_MSG_LEN 256 - TRACE_EVENT(batadv_dbg, TP_PROTO(struct batadv_priv *bat_priv, @@ -40,16 +38,13 @@ TRACE_EVENT(batadv_dbg, TP_STRUCT__entry( __string(device, bat_priv->soft_iface->name) __string(driver, KBUILD_MODNAME) - __dynamic_array(char, msg, BATADV_MAX_MSG_LEN) + __vstring(msg, vaf->fmt, vaf->va) ), TP_fast_assign( __assign_str(device, bat_priv->soft_iface->name); __assign_str(driver, KBUILD_MODNAME); - WARN_ON_ONCE(vsnprintf(__get_dynamic_array(msg), - BATADV_MAX_MSG_LEN, - vaf->fmt, - *vaf->va) >= BATADV_MAX_MSG_LEN); + __assign_vstr(msg, vaf->fmt, vaf->va); ), TP_printk( -- 2.35.1

7 months, 2 weeks

[PATCH 5.18 1046/1095] batman-adv: tracing: Use the new __vstring() helper

by Greg Kroah-Hartman

7 months, 2 weeks

[PATCH 1/3] alfred: add missing alfred_event_notify_v0 struct documentation

by Marek Lindner

Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- packet.h | 1 + 1 file changed, 1 insertion(+) diff --git a/packet.h b/packet.h index b8d528e..c0723b8 100644 --- a/packet.h +++ b/packet.h @@ -247,6 +247,7 @@ struct alfred_event_register_v0 { * struct alfred_event_notify_v0 - event notification message * @header: TLV header describing the complete packet * @type: Type of the data triggering the event + * @source: Mac address of the original source of the data * * Sent by the daemon to client on data record update */ -- 2.36.1

7 months, 3 weeks

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N August 2022