B.A.T.M.A.N January 2021

b.a.t.m.a.n@lists.open-mesh.org

6 participants
8 discussions

[PATCH net 00/12] net: iflink and link-netnsid fixes
by Sabrina Dubroca 14 May '22

14 May '22

In a lot of places, we use this kind of comparison to detect if a device has a lower link: dev->ifindex != dev_get_iflink(dev) This seems to be a leftover of the pre-netns days, when the ifindex was unique over the whole system. Nowadays, with network namespaces, it's very easy to create a device with the same ifindex as its lower link: ip netns add main ip netns add peer ip -net main link add dummy0 type dummy ip -net main link add link dummy0 macvlan0 netns peer type macvlan ip -net main link show type dummy 9: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop ... ip -net peer link show type macvlan 9: macvlan0@if9: <BROADCAST,MULTICAST> mtu 1500 qdisc noop ... To detect if a device has a lower link, we can simply check the existence of the dev->netdev_ops->ndo_get_iflink operation, instead of checking its return value. In particular, I attempted to fix one of these checks in commit feadc4b6cf42 ("rtnetlink: always put IFLA_LINK for links with a link-netnsid"), but this patch isn't correct, since tunnel devices can export IFLA_LINK_NETNSID without IFLA_LINK. That patch needs to be reverted. This series will fix all those bogus comparisons, and export missing IFLA_LINK_NETNSID attributes in bridge and ipv6 dumps. ipvlan and geneve are also missing the get_link_net operation, so userspace can't know when those device are cross-netns. There are a couple of other device types that have an ndo_get_iflink op but no get_link_net (virt_wifi, ipoib), and should probably also have a get_link_net. Sabrina Dubroca (12): ipvlan: add get_link_net geneve: add get_link_net Revert "rtnetlink: always put IFLA_LINK for links with a link-netnsid" rtnetlink: always put IFLA_LINK for links with ndo_get_iflink bridge: always put IFLA_LINK for ports with ndo_get_iflink bridge: advertise IFLA_LINK_NETNSID when dumping bridge ports ipv6: always put IFLA_LINK for devices with ndo_get_iflink ipv6: advertise IFLA_LINK_NETNSID when dumping ipv6 addresses net: link_watch: fix operstate when the link has the same index as the device net: link_watch: fix detection of urgent events batman-adv: fix iflink detection in batadv_is_on_batman_iface batman-adv: fix detection of lower link in batadv_get_real_netdevice drivers/net/can/vxcan.c | 2 +- drivers/net/geneve.c | 8 ++++++++ drivers/net/ipvlan/ipvlan_main.c | 9 +++++++++ drivers/net/veth.c | 2 +- include/net/rtnetlink.h | 4 ++++ net/batman-adv/hard-interface.c | 4 ++-- net/bridge/br_netlink.c | 4 +++- net/core/link_watch.c | 4 ++-- net/core/rtnetlink.c | 25 ++++++++++++------------- net/ipv6/addrconf.c | 11 ++++++++++- 10 files changed, 52 insertions(+), 21 deletions(-) -- 2.28.0

3 5

WARNING in sta_info_alloc
by syzbot 21 Jul '21

21 Jul '21

Hello, syzbot found the following issue on: HEAD commit: 549738f1 Linux 5.9-rc8 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15b97ba3900000 kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3cc963d91c dashboard link: https://syzkaller.appspot.com/bug?extid=45d7c243c006f39dc55a compiler: gcc (GCC) 10.1.0-syz 20200507 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12bae9c0500000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1099b1c0500000 The issue was bisected to: commit 643c332d519bdfbf80d21f40d1c0aa0ccf3ec1cb Author: Zi Shen Lim <zlim.lnx(a)gmail.com> Date: Thu Jun 9 04:18:50 2016 +0000 arm64: bpf: optimize LD_ABS, LD_IND bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11d44477900000 final oops: https://syzkaller.appspot.com/x/report.txt?x=13d44477900000 console output: https://syzkaller.appspot.com/x/log.txt?x=15d44477900000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+45d7c243c006f39dc55a(a)syzkaller.appspotmail.com Fixes: 643c332d519b ("arm64: bpf: optimize LD_ABS, LD_IND") ------------[ cut here ]------------ WARNING: CPU: 0 PID: 6879 at net/mac80211/ieee80211_i.h:1447 ieee80211_get_sband net/mac80211/ieee80211_i.h:1447 [inline] WARNING: CPU: 0 PID: 6879 at net/mac80211/ieee80211_i.h:1447 sta_info_alloc+0x1900/0x1f90 net/mac80211/sta_info.c:469 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 6879 Comm: syz-executor071 Not tainted 5.9.0-rc8-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x198/0x1fd lib/dump_stack.c:118 panic+0x382/0x7fb kernel/panic.c:231 __warn.cold+0x20/0x4b kernel/panic.c:600 report_bug+0x1bd/0x210 lib/bug.c:198 handle_bug+0x38/0x90 arch/x86/kernel/traps.c:234 exc_invalid_op+0x14/0x40 arch/x86/kernel/traps.c:254 asm_exc_invalid_op+0x12/0x20 arch/x86/include/asm/idtentry.h:536 RIP: 0010:ieee80211_get_sband net/mac80211/ieee80211_i.h:1447 [inline] RIP: 0010:sta_info_alloc+0x1900/0x1f90 net/mac80211/sta_info.c:469 Code: 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 f0 04 00 00 49 8b 9f 60 01 00 00 e9 fc f6 ff ff e8 80 20 b6 f9 <0f> 0b e8 e9 62 66 00 31 ff 89 c3 89 c6 e8 ce 1c b6 f9 85 db 74 1d RSP: 0018:ffffc9000539f498 EFLAGS: 00010293 RAX: 0000000000000000 RBX: 0000000000000001 RCX: ffffffff87c01d61 RDX: ffff8880a91ec3c0 RSI: ffffffff87c01e10 RDI: 0000000000000005 RBP: ffff8880896e0c80 R08: 0000000000000001 R09: ffffffff8d0c29e7 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: ffff8880896e31b0 R14: dffffc0000000000 R15: ffff888092f06000 ieee80211_add_station+0x28c/0x660 net/mac80211/cfg.c:1586 rdev_add_station net/wireless/rdev-ops.h:190 [inline] nl80211_new_station+0xde7/0x1440 net/wireless/nl80211.c:6294 genl_family_rcv_msg_doit net/netlink/genetlink.c:669 [inline] genl_family_rcv_msg net/netlink/genetlink.c:714 [inline] genl_rcv_msg+0x61d/0x980 net/netlink/genetlink.c:731 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2470 genl_rcv+0x24/0x40 net/netlink/genetlink.c:742 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline] netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:651 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:671 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2353 ___sys_sendmsg+0xf3/0x170 net/socket.c:2407 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2440 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x441999 Code: e8 dc 05 03 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 0d fc ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007ffd9fa54bf8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441999 RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000000000005 RBP: 000000306e616c77 R08: 0000000000000000 R09: 0000002000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000032 R13: 0000000000000000 R14: 000000000000000c R15: 0000000000000004 Kernel Offset: disabled Rebooting in 86400 seconds.. --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches

3 3

batman-adv related query
by Moullick Mehra 30 Jan '21

30 Jan '21

Hi, I have been using BATMAN-ADV for a while now. Just had a question. Is there any way to add a nonce value to the packet header? The reason being that I want to add an authentication mechanism where the firewall permits only selected headers that have this nonce. Hope this makes sense. Thanks and Regards Moullick Mehra

2 3

Mobile Vehicle Mesh Network
by Scooter Willis 30 Jan '21

30 Jan '21

Doing some research to see what options are available for a hybrid mobile-mesh network. The application would be a large warehouse with fixed nodes overhead connected via ethernet/POE. On the warehouse floor would be some number of robots that as they travel would go in and out of range for an overhead access point. On the robot would be 2-5 computer devices that would connect to the access point on the robot via ethernet. Would have one gateway for the entire warehouse in that all internet traffic would be local. If the robot which is moving has the equivalent access point mesh node as the static access points overhead would want very quick handoff to the next access point where signal strength of the wifi would be the reason to pick a specific access point. The 2-5 computers on the robot should see the minimal impact when the access point switches to another overhead access point. For the 2-5 computers on the device want to minimize cost/wifi noise and the reason to have them plugged into a local switch. For batman-adv wanted to see if you could provide any guidance that it would work in this configuration where some number of mesh nodes are dynamic and are moving. It may also be optimal for a robot not in range of overhead wireless to connect to other moving robots that are mesh nodes.

3 2

batman-adv: Fix names for kernel-doc blocks
by Sven Eckelmann 20 Jan '21

20 Jan '21

kernel-doc can only correctly identify the documented function or struct when the name in the first kernel-doc line references it. But some of the kernel-doc blocks referenced a different function/struct then it actually documented. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index fd7ba6bbdf85eb7d7240cfd50e44d522335bca13..0a367a92b5f62afd5a8635ad270353291cd36464 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -1564,7 +1564,7 @@ static int batadv_dat_get_dhcp_message_type(struct sk_buff *skb) } /** - * batadv_dat_get_dhcp_yiaddr() - get yiaddr from a DHCP packet + * batadv_dat_dhcp_get_yiaddr() - get yiaddr from a DHCP packet * @skb: the DHCP packet to parse * @buf: a buffer to store the yiaddr in * diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 854e5ff28a3fe5d2d57862142be45d56a403c448..4f250551a589ca5c7f495612e826e6fd5234dc79 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -828,7 +828,7 @@ batadv_mcast_bridge_log(struct batadv_priv *bat_priv, } /** - * batadv_mcast_flags_logs() - output debug information about mcast flag changes + * batadv_mcast_flags_log() - output debug information about mcast flag changes * @bat_priv: the bat priv with all the soft interface information * @flags: TVLV flags indicating the new multicast state * diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c index 97bcf149633d850ff4fcece6d7dc0d799adb1444..1c002236e351b75f8888a35c7423e3ac6244df42 100644 --- a/net/batman-adv/netlink.c +++ b/net/batman-adv/netlink.c @@ -193,7 +193,7 @@ static int batadv_netlink_mesh_fill_ap_isolation(struct sk_buff *msg, } /** - * batadv_option_set_ap_isolation() - Set ap_isolation from genl msg + * batadv_netlink_set_mesh_ap_isolation() - Set ap_isolation from genl msg * @attr: parsed BATADV_ATTR_AP_ISOLATION_ENABLED attribute * @bat_priv: the bat priv with all the soft interface information * @@ -757,7 +757,7 @@ batadv_netlink_tp_meter_start(struct sk_buff *skb, struct genl_info *info) } /** - * batadv_netlink_tp_meter_start() - Cancel a running tp_meter session + * batadv_netlink_tp_meter_cancel() - Cancel a running tp_meter session * @skb: received netlink message * @info: receiver information * diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index d4e10005df6cd2936a3132e1ad7bd8bf3c1d99b6..f9e35a2d2b1ac15aa851c3279a262827a01f9bff 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -131,7 +131,7 @@ static u32 batadv_tp_cwnd(u32 base, u32 increment, u32 min) } /** - * batadv_tp_updated_cwnd() - update the Congestion Windows + * batadv_tp_update_cwnd() - update the Congestion Windows * @tp_vars: the private data of the current TP meter session * @mss: maximum segment size of transmission * diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 2f96e96a5ca4ddb800f9bac66a118a6f97d86d89..490503dc5581346af7d94e9fc18e6858e6ecfee1 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -228,7 +228,8 @@ struct batadv_hard_iface { }; /** - * struct batadv_orig_ifinfo - B.A.T.M.A.N. IV private orig_ifinfo members + * struct batadv_orig_ifinfo_bat_iv - B.A.T.M.A.N. IV private orig_ifinfo + * members */ struct batadv_orig_ifinfo_bat_iv { /**

1 0

[PATCH] batctl: Don't stop when create_interface detected existing interface
by Sven Eckelmann 15 Jan '21

15 Jan '21

"batctl meshif bat0 interface add ..." should never be called in parallel. But when something still does this, it could be that the code first detects the missing meshif and then tries to create it - which fails when another process requested the creation of the same interface slightly before batctl did it. But this should not prevent batctl to add the lower interface to the meshif. It is not really important that the batctl process was the one which created it - only that it exists is important. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface.c b/interface.c index 77ca1a0..7f77459 100644 --- a/interface.c +++ b/interface.c @@ -526,7 +526,7 @@ static int interface(struct state *state, int argc, char **argv) ifmaster = if_nametoindex(state->mesh_iface); if (!manual_mode && !ifmaster && rest_argv[0][0] == 'a') { ret = create_interface(state->mesh_iface, &create_params); - if (ret < 0) { + if (ret < 0 && ret != -EEXIST) { fprintf(stderr, "Error - failed to create batman-adv interface: %s\n", strerror(-ret)); -- 2.29.2

1 0

Re: INFO: trying to register non-static key in l2cap_sock_teardown_cb
by syzbot 11 Jan '21

11 Jan '21

syzbot has bisected this issue to: commit 4680a7ee5db27772af40d83393fa0fb955b745b7 Author: Miklos Szeredi <mszeredi(a)redhat.com> Date: Sat Oct 1 05:32:33 2016 +0000 fuse: remove duplicate cs->offset assignment bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11fc80e7500000 start commit: 73b7a604 net: dsa: bcm_sf2: support BCM4908's integrated s.. git tree: net-next final oops: https://syzkaller.appspot.com/x/report.txt?x=13fc80e7500000 console output: https://syzkaller.appspot.com/x/log.txt?x=15fc80e7500000 kernel config: https://syzkaller.appspot.com/x/.config?x=9ce34124da4c882b dashboard link: https://syzkaller.appspot.com/bug?extid=a41dfef1d2e04910eb2e syz repro: https://syzkaller.appspot.com/x/repro.syz?x=166ee4cf500000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1337172f500000 Reported-by: syzbot+a41dfef1d2e04910eb2e(a)syzkaller.appspotmail.com Fixes: 4680a7ee5db2 ("fuse: remove duplicate cs->offset assignment") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

1 0

WARNING in rds_rdma_extra_size
by syzbot 09 Jan '21

09 Jan '21

Hello, syzbot found the following issue on: HEAD commit: 6207214a Merge tag 'afs-fixes-04012021' of git://git.kerne.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=146967c0d00000 kernel config: https://syzkaller.appspot.com/x/.config?x=8aa30b9da402d224 dashboard link: https://syzkaller.appspot.com/bug?extid=1bd2b07f93745fa38425 compiler: gcc (GCC) 10.1.0-syz 20200507 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1351c11f500000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1710cb50d00000 The issue was bisected to: commit fdadd04931c2d7cd294dc5b2b342863f94be53a3 Author: Daniel Borkmann <daniel(a)iogearbox.net> Date: Tue Dec 11 11:14:12 2018 +0000 bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10056f70d00000 final oops: https://syzkaller.appspot.com/x/report.txt?x=12056f70d00000 console output: https://syzkaller.appspot.com/x/log.txt?x=14056f70d00000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+1bd2b07f93745fa38425(a)syzkaller.appspotmail.com Fixes: fdadd04931c2 ("bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K") ------------[ cut here ]------------ WARNING: CPU: 1 PID: 8462 at mm/page_alloc.c:4976 __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5011 Modules linked in: CPU: 1 PID: 8462 Comm: syz-executor292 Not tainted 5.11.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:__alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:4976 Code: 00 00 0c 00 0f 85 a7 00 00 00 8b 3c 24 4c 89 f2 44 89 e6 c6 44 24 70 00 48 89 6c 24 58 e8 d0 d7 ff ff 49 89 c5 e9 ea fc ff ff <0f> 0b e9 b5 fd ff ff 89 74 24 14 4c 89 4c 24 08 4c 89 74 24 18 e8 RSP: 0018:ffffc9000169f790 EFLAGS: 00010246 RAX: 0000000000000000 RBX: 1ffff920002d3ef6 RCX: 0000000000000000 RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000040dc0 RBP: 0000000000040dc0 R08: 0000000000000000 R09: 0000000000000000 R10: ffffffff81b1f7f1 R11: 0000000000000000 R12: 0000000000000018 R13: 0000000000000018 R14: 0000000000000000 R15: 0000000ffffff1f0 FS: 0000000000f3c880(0000) GS:ffff8880b9f00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f6b332916c0 CR3: 00000000133c3000 CR4: 0000000000350ee0 Call Trace: alloc_pages_current+0x18c/0x2a0 mm/mempolicy.c:2267 alloc_pages include/linux/gfp.h:547 [inline] kmalloc_order+0x2e/0xb0 mm/slab_common.c:837 kmalloc_order_trace+0x14/0x120 mm/slab_common.c:853 kmalloc_array include/linux/slab.h:592 [inline] kcalloc include/linux/slab.h:621 [inline] rds_rdma_extra_size+0xb2/0x3b0 net/rds/rdma.c:568 rds_rm_size net/rds/send.c:928 [inline] rds_sendmsg+0x20d7/0x3020 net/rds/send.c:1265 sock_sendmsg_nosec net/socket.c:652 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:672 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2345 ___sys_sendmsg+0xf3/0x170 net/socket.c:2399 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2432 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x440359 Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007ffe89376b68 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440359 RDX: 0000000000000000 RSI: 0000000020001600 RDI: 0000000000000003 RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401b60 R13: 0000000000401bf0 R14: 0000000000000000 R15: 0000000000000000 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches

1 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N January 2021