QoS over batman-adv
by Xuebing Wang
Hi Simon and community,
We have been using batman-adv on OpenWRT 15.05 + ath9k chips for over
3 years and it works great.
We are exploring the idea of QoS over batman-adv to transmit small
quantity of high priority data. Any suggestions? Thanks.
Xuebing Wang
2 days, 8 hours
Network stops passing traffic randomly
by smartwires＠gmail.com
I have been battling a weird problem recently, I have this problem occurring on two (2) separate networks, one with 2 nodes and the other with 3 nodes. What happens is the network is fine and all of a sudden the clients can not reach the Internet, This what I have observed. on both Openwrt 19.07, 18.07. A reboot of the gateway corrects the problem.
1. Gateway is up and running and able the reach the internet.
2. batctl o show the neighbor/s
3. batctl ping [MAC] fails
root@Main-GW:~# batctl o
[B.A.T.M.A.N. adv openwrt-2018.1-5, MainIF/MAC: mesh0/e8:5b:b7:00:10:73 (bat0/22:55:4d:3e:5f:8f BATMAN_IV)]
Originator last-seen (#/255) Nexthop [outgoingIF]
* e8:5b:b7:00:10:6b 0.880s (255) e8:5b:b7:00:10:6b [ mesh0]
root@Main-GW:~# batctl ping e8:5b:b7:00:10:6b
PING e8:5b:b7:00:10:6b (e8:5b:b7:00:10:6b) 20(48) bytes of data
Reply from host e8:5b:b7:00:10:6b timed out
Reply from host e8:5b:b7:00:10:6b timed out
Reply from host e8:5b:b7:00:10:6b timed out
Reply from host e8:5b:b7:00:10:6b timed out
2 days, 15 hours
Re: Network stops passing traffic randomly
by Sven Eckelmann
[please don't send me private mails about batman-adv - unless you have a
really good reason to do so. And if not stated otherwise, I must assume
that you actually wanted to send you message to the mailing list]
On Thursday, 28 May 2020 21:18:36 CEST Steve Newcomb wrote:
> > My first guess is that the underlying interfaces (mesh0) stopped to transport
> > unicast frames. Did you check this by setting an IP on mesh0 and ping between
> > these devices using the IPv4 ping?
> Not sure what the phrase "to set an IP on mesh0" means, if not simply to
> endow the corresponding bridge with a static IP. Which is what I'm doing.
>
> Not sure what "IPv4 ping" means. I've disabled IPv6, so I'm not using
> anything but IPv4.
I am assuming that mesh0 is the device which was added to bat0 as slave.
Please replace this with whatever you are using
# on device 1
ip addr add 192.168.23.1/24 dev mesh0
# on device 2
ip addr add 192.168.23.2/24 dev mesh0
> If "IPv4 ping" means "the ordinary Linux ping command", then, yes, I've
> tried that.
The IPv4 ping was just a placeholder for "not batman-adv ping packets". So you
can also use ICMPv6 if you prefer. Just make sure to send it over the
underlying ("slave") interface of batman-adv. And not on bat0 or any higher
layer bridge/vlan/... interface.
With the addresses mentioned earlier:
# on device 1
ping 192.168.23.2
# on device 2
ping 192.168.23.1
And also observe with tcpdump what is received by the other end.
> 100% packet loss when the offline condition occurs. Batctl
> o, on the other hand, looks just fine.
Sounds to me like "mesh0" is still able to transport broadcast frames (which
are used for the OGMs - which "create" the originator lists in `batctl o`).
And if you cannot send unicast frames anymore on mesh0 then something is wrong
with the unicast part.
For example, when you are using encryption for the mesh0 link, maybe the group
key is still set correctly but something happened with the pairwise key and it
is now "corrupted".
Kind regards,
Sven
2 days, 15 hours
[PATCH 0/3] pull request for net-next: batman-adv 2020-05-26
by Simon Wunderlich
Hi David,
here is a small cleanup pull request of batman-adv to go into net-next.
Please pull or let me know of any problem!
Thank you,
Simon
The following changes since commit 1a33e10e4a95cb109ff1145098175df3113313ef:
net: partially revert dynamic lockdep key changes (2020-05-04 12:05:56 -0700)
are available in the Git repository at:
git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20200526
for you to fetch changes up to 9ad346c90509ebd983f60da7d082f261ad329507:
batman-adv: Revert "disable ethtool link speed detection when auto negotiation off" (2020-05-26 09:23:33 +0200)
----------------------------------------------------------------
This cleanup patchset includes the following patches:
- Fix revert dynamic lockdep key changes for batman-adv,
by Sven Eckelmann
- use rcu_replace_pointer() where appropriate, by Antonio Quartulli
- Revert "disable ethtool link speed detection when auto negotiation
off", by Sven Eckelmann
----------------------------------------------------------------
Antonio Quartulli (1):
batman-adv: use rcu_replace_pointer() where appropriate
Sven Eckelmann (2):
batman-adv: Revert "Drop lockdep.h include for soft-interface.c"
batman-adv: Revert "disable ethtool link speed detection when auto negotiation off"
net/batman-adv/bat_v_elp.c | 15 +--------------
net/batman-adv/gateway_client.c | 4 ++--
net/batman-adv/hard-interface.c | 4 ++--
net/batman-adv/routing.c | 4 ++--
net/batman-adv/soft-interface.c | 1 +
5 files changed, 8 insertions(+), 20 deletions(-)
4 days, 14 hours
Batman-adv packet retranslation
by Alexey Ermakov
Hi, All.
There is a problem with retranslating packets in B.A.T.M.A.N. V mode.
I have 3 stations, st1, st2 and st3 with one active network interface.
This interface is configured so that st1 and st3 can see only st2.
I expect that if I join these stations in a bat0 network, then station
2 will act as a repeater and all three stations will be visible in the
bat0 network.
This works fine if I selecting B.A.T.M.A.N. IV algorithm, but doesn't
work in B.A.T.M.A.N.V.
--
Ermakov Alexey.
5 days, 19 hours
Re: Network stops passing traffic randomly
by Sven Eckelmann
On Monday, 25 May 2020 15:19:22 CEST Daniel Ghansah wrote:
> [B.A.T.M.A.N. adv openwrt-2018.1-5, MainIF/MAC: mesh0/e8:5b:b7:00:10:73
Just noticed another thing - why is your revision of batman-adv so low? The
OpenWrt 18.06.x version of batman-adv is already at 2018.1-11.
Kind regards,
Sven
5 days, 23 hours
Re: Network stops passing traffic randomly
by Sven Eckelmann
On Monday, 25 May 2020 15:19:22 CEST Daniel Ghansah wrote:
> Hi Sven,
> Yes I did ping via the IP, there is no response, I am using IPV4
Ok, when your underlying layer (mesh0) is not working then you should not
expect batman-adv to work.
Btw. the `batctl dc` output doesn't look like your tested the IPv4 ping
on mesh0 but on bat0 - not what I've asked for.
Kind regards,
Sven
5 days, 23 hours
[PATCH] batman-adv: use rcu_replace_pointer() where appropriate
by Antonio Quartulli
In a63fc6b7 ("rcu: Upgrade rcu_swap_protected() to rcu_replace_pointer()")
a new helper macro named rcu_replace_pointer() was introduced to
simplify code requiring to switch an rcu pointer to a new value while
extracting the old one.
Use rcu_replace_pointer() where appropriate to make code slimer.
Signed-off-by: Antonio Quartulli <a(a)unstable.cc>
---
compat-include/linux/rcupdate.h | 27 +++++++++++++++++++++++++++
net/batman-adv/gateway_client.c | 4 ++--
net/batman-adv/hard-interface.c | 4 ++--
net/batman-adv/routing.c | 4 ++--
4 files changed, 33 insertions(+), 6 deletions(-)
create mode 100644 compat-include/linux/rcupdate.h
diff --git a/compat-include/linux/rcupdate.h b/compat-include/linux/rcupdate.h
new file mode 100644
index 00000000..731aa951
--- /dev/null
+++ b/compat-include/linux/rcupdate.h
@@ -0,0 +1,27 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (C) 2020 B.A.T.M.A.N. contributors:
+ *
+ * Antonio Quartulli
+ *
+ * This file contains macros for maintaining compatibility with older versions
+ * of the Linux kernel.
+ */
+
+#ifndef _NET_BATMAN_ADV_COMPAT_LINUX_RCUPDATE_H_
+#define _NET_BATMAN_ADV_COMPAT_LINUX_RCUPDATE_H_
+
+#include <linux/version.h>
+#include_next <linux/rcupdate.h>
+
+#if LINUX_VERSION_IS_LESS(5, 5, 0)
+
+#define rcu_replace_pointer(rcu_ptr, ptr, c) \
+({ \
+ typeof(ptr) __tmp = rcu_dereference_protected((rcu_ptr), (c)); \
+ rcu_assign_pointer((rcu_ptr), (ptr)); \
+ __tmp; \
+})
+
+#endif /* LINUX_VERSION_IS_LESS(5, 5, 0) */
+
+#endif /* _NET_BATMAN_ADV_COMPAT_LINUX_RCUPDATE_H_ */
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index e22e4928..a18dcc68 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -146,8 +146,8 @@ static void batadv_gw_select(struct batadv_priv *bat_priv,
if (new_gw_node)
kref_get(&new_gw_node->refcount);
- curr_gw_node = rcu_dereference_protected(bat_priv->gw.curr_gw, 1);
- rcu_assign_pointer(bat_priv->gw.curr_gw, new_gw_node);
+ curr_gw_node = rcu_replace_pointer(bat_priv->gw.curr_gw, new_gw_node,
+ true);
if (curr_gw_node)
batadv_gw_node_put(curr_gw_node);
diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index c7e98a40..3a256af9 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -473,8 +473,8 @@ static void batadv_primary_if_select(struct batadv_priv *bat_priv,
if (new_hard_iface)
kref_get(&new_hard_iface->refcount);
- curr_hard_iface = rcu_dereference_protected(bat_priv->primary_if, 1);
- rcu_assign_pointer(bat_priv->primary_if, new_hard_iface);
+ curr_hard_iface = rcu_replace_pointer(bat_priv->primary_if,
+ new_hard_iface, 1);
if (!new_hard_iface)
goto out;
diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
index 3632bd97..d343382e 100644
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -71,13 +71,13 @@ static void _batadv_update_route(struct batadv_priv *bat_priv,
* the code needs to ensure the curr_router variable contains a pointer
* to the replaced best neighbor.
*/
- curr_router = rcu_dereference_protected(orig_ifinfo->router, true);
/* increase refcount of new best neighbor */
if (neigh_node)
kref_get(&neigh_node->refcount);
- rcu_assign_pointer(orig_ifinfo->router, neigh_node);
+ curr_router = rcu_replace_pointer(orig_ifinfo->router, neigh_node,
+ true);
spin_unlock_bh(&orig_node->neigh_list_lock);
batadv_orig_ifinfo_put(orig_ifinfo);
--
2.26.2
1 week, 2 days
