The sysfs support in batman-adv is deprecated since a while and will be
removed completely next year.
All tools which were known to the batman-adv development team are
supporting the batman-adv netlink interface since a while. Thus
disabling CONFIG_BATMAN_ADV_SYSFS by default should not cause problems on
most systems. It is still possible to enable it in case it is still
required in a specific setup.
Signed-off-by: Sven Eckelmann <sven(a)narfation.org>
Makefile | 2 +-
README.external.rst | 2 +-
net/batman-adv/Kconfig | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index e391a1e7..448a14d6 100644
@@ -17,7 +17,7 @@ export CONFIG_BATMAN_ADV_NC=n
# B.A.T.M.A.N. multicast optimizations:
# B.A.T.M.A.N. sysfs support:
# B.A.T.M.A.N. tracing support:
# B.A.T.M.A.N. V routing algorithm (experimental):
diff --git a/README.external.rst b/README.external.rst
index 6db0117d..5a5da14e 100644
@@ -49,7 +49,7 @@ module). Available options and their possible values are
* ``CONFIG_BATMAN_ADV_DAT=[y*|n]`` (B.A.T.M.A.N. Distributed ARP Table)
* ``CONFIG_BATMAN_ADV_MCAST=[y*|n]`` (B.A.T.M.A.N. multicast optimizations)
* ``CONFIG_BATMAN_ADV_NC=[y|n*]`` (B.A.T.M.A.N. Network Coding)
- * ``CONFIG_BATMAN_ADV_SYSFS=[y*|n]`` (B.A.T.M.A.N. sysfs support)
+ * ``CONFIG_BATMAN_ADV_SYSFS=[y|n*]`` (B.A.T.M.A.N. sysfs support)
* ``CONFIG_BATMAN_ADV_TRACING=[y|n*]`` (B.A.T.M.A.N. tracing support)
* ``CONFIG_BATMAN_ADV_BATMAN_V=[y*|n]`` (B.A.T.M.A.N. V routing algorithm)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index 045b2b18..c762758a 100644
@@ -100,7 +100,6 @@ config BATMAN_ADV_DEBUG
bool "batman-adv sysfs entries"
depends on BATMAN_ADV
- default y
Say Y here if you want to enable batman-adv device configuration and
status interface through sysfs attributes. It is replaced by the
After some time of playing with the B.A.T.M.A.N protocol and
net-interface on OpenWRT and Debian I was thinking to use it with
the servers I use everyday (and maybe on routers/appliances I have
So I started an effort...
(As a background) I already ported some applications to FreeBSD [and I'm
maintaining them] and
also I did work already on the Linux emulation layer of FreeBSD (FreeBSD
has a Linux syscall-emulation and Linux-KPI layers).
So my approach (as naturally I didn't expect the build of batman-adv.ko
to be successful as is),
was based on the approach that we [at FreeBSD] did to port Linux's
I ended up in adding some header-files to FreeBSD Linux-KPI (like
average.h, percpu.h, ...).
Now I'm at a state that Netlink blocks me and I'm to determine next step :-)
[Which I don't assume it being trivial with my current approach]
So I'd like to ask:
1- Is it better approach to "rewrite" batman-adv.ko [at least
Netlink-ish (let's call "Linuxism") parts] than what I'm doing now?
2- Any other efforts are being done out there?
3- is batmand deprecated [So I should mainly focus on batman-adv.ko]?
4- any other comments do you have? :D
P.S. sorry if I'm not really good at starting conversation from scratch
and out-of-nowhere :D
but I hope by continuing the collaboration we can have better (more
enriched) FreeBSD and better (as in more portable) B.A.T.M.A.N :-)
Best regards, MMokhi.
On Saturday, 28 December 2019 03:32:17 CET 张鹏 wrote:
> Thank you very much for your reply!
> I have ported the pre-2019.2 version of batman to the 3.3 kernel and it is available for doing
Please don't do this. Now you are not only having the known bugs from Linux
3.3 but also the known bugs  from the pre-2019.2 batman-adv.
The correct approach is to get your used software updated to a non-EOL
The platform I work on is openwrt mips, the kernel I use is version 3.3; the version using batman is relatively low, and I want to use the newer version batman on version 3.3, but I encounter many problems during compilation, and I don't know it Whether it works ?
please help me!
thank you very much !
syzbot found the following crash on:
HEAD commit: ef798c30 x86, kcsan: Enable KCSAN for x86
git tree: https://github.com/google/ktsan.git kcsan
console output: https://syzkaller.appspot.com/x/log.txt?x=156e052ee00000
kernel config: https://syzkaller.appspot.com/x/.config?x=8077a73bd604a9d4
dashboard link: https://syzkaller.appspot.com/bug?extid=c051abeff5e2e8ac40f0
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
Unfortunately, I don't have any reproducer for this crash yet.
IMPORTANT: if you fix the bug, please add the following tag to the commit:
BUG: KCSAN: data-race in add_timer / timer_clear_idle
read to 0xffff88812be1b6e4 of 1 bytes by task 23 on cpu 1:
forward_timer_base kernel/time/timer.c:892 [inline]
__mod_timer kernel/time/timer.c:1009 [inline]
mod_timer kernel/time/timer.c:1100 [inline]
queue_delayed_work include/linux/workqueue.h:509 [inline]
batadv_mcast_start_timer net/batman-adv/multicast.c:71 [inline]
write to 0xffff88812be1b6e4 of 1 bytes by task 0 on cpu 0:
tick_nohz_restart_sched_tick kernel/time/tick-sched.c:839 [inline]
Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.4.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller(a)googlegroups.com.
syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.