On Tuesday 21 April 2015 11:41:48 Marek Lindner wrote:
On Friday, April 17, 2015 19:40:27 Sven Eckelmann wrote:
The current approach for the compat layer is to include the compat.h file at exactly the right time to provide additional functionality and to live patch the batman-adv sources. This has the problem that the compat.h file becomes harder to read over time. Also live patching and adding of missing functionality partially conflict. This becomes obvious when the include order in some files is different compared to the one the author of an compat.h entry expected.
A different approach is to inject intermediate header files which add additional features. This allows to reduce the size of compat.h and only leaves the live patching part in it. The compat.h can then added automatically to each compile run before anything else is included. compat.h has therefore the control which headers must be included before the live patching of the batman-adv source can begin.
Signed-off-by: Sven Eckelmann sven@narfation.org
Applied in revision 8746f0f.
The patch you've added is not the one I've send. All files in compat-include are missing now in your commit.
Btw. I had prepared a patch v5 which fixed some merge conflicts with the state of the next from yesterday.
Kind regards, Sven