Re: [B.A.T.M.A.N.] [PATCHv2 3/3] batctl: Use memleak/error path free implementation of hash_resize

On Tuesday 27 May 2014 16:23:32 Sven Eckelmann wrote:

The current implementation of hash_resize uses hash_add directly to initialize a new hash table. But hash_add has two possible situations when it returns an error and hash_resize would leak the data:

• data already exists
• malloc fails

The check for the duplicated data is not really harmful (beside increasing the time to re-add elements) but the malloc can potentially return an error. This malloc is unnecessary and just takes extra time. Instead the bucket from the old hash table can be re-used.

Signed-off-by: Sven Eckelmann sven@narfation.org

v2:

• fixed commit message

hash.c | 72 ++++++++++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 44 insertions(+), 28 deletions(-)

Applied in revision 6f03fcf.

Thanks, Marek