Re: [B.A.T.M.A.N.] [RFC 1/5] batman-adv: ELP - adding basic infrastructure

On Friday, March 23, 2012 08:50:44 Andrew Lunn wrote:

I guess you are not on the ARM linux kernel list. A couple of months ago, Rusty had a rant about the last entry in such structures should always have a , even though its optional. As part of the ARM cleanup work he had to append a new entry to many board files, and found it very error prone. Sometime you forget to add the , to the line before, and then the compiler spits out a compile error. So since then i've got into the habit of always having a , on the last entry.

No, I don't follow the ARM list. If we wanted the comma to be there we should change the entire module. At the moment we never put the comma after the last item.

Regards, Marek