Re: [B.A.T.M.A.N.] [PATCHv3 5/7] batman-adv: Distributed ARP Table - add snooping functions for ARP messages

Hello Andrew,

On Wed, Nov 23, 2011 at 05:11:51 +0100, Andrew Lunn wrote:

Hi Antonio

...

• n = neigh_lookup(&arp_tbl, &ip_dst, primary_if->soft_iface);
• /* check if it is a valid neigh entry */
• if (!n || !(n->nud_state & NUD_CONNECTED))

• goto out;
  

• skb_new = arp_create(ARPOP_REPLY, ETH_P_ARP, ip_src,

• 	     primary_if->soft_iface, ip_dst, hw_src, n->ha,
  

• 	     hw_src);
  

• unicast_send_skb(skb_new, bat_priv);

Can arp_create fail? Should you check the return value before calling unicast_send_skb()?

Thank you for the comment. Anyway this patchset is now a bit "old", because after posting it I continued to work on it and to correct some bugs (like this one).

Therefore I would not go ahead in inspecting these patches. Sorry for this.

Cheers,