Re: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: enable roaming packets to carry flags

On Tue, Jun 26, 2012 at 11:18:29PM +0200, Sven Eckelmann wrote:

I am not 100% sure because I haven't checked the code, but couldn't it be the case that we send random bits inside reserved at the moment? At least I cannot remember the part of the code that initialized reserver to any specific value. That would make the change incompatible with older batman-adv version.

Damn, that's true! It is not initialised anywhere.... What if I append a new field to the roam_adv_packet struct? Old version will ignore it and there is no size check to drop packets longer than expected.

Cheers,