On Tue, Nov 01, 2011 at 11:47:12AM +0100, Marek Lindner wrote:
On Sunday, October 30, 2011 23:51:08 Simon Wunderlich
wrote:
+struct bcast_duplist_entry {
+ uint8_t orig[ETH_ALEN];
+ uint16_t crc;
+ unsigned long entrytime;
+};
struct bat_priv {
atomic_t mesh_state;
@@ -185,6 +190,8 @@ struct bat_priv {
struct list_head tt_req_list; /* list of pending tt_requests */
struct list_head tt_roam_list;
struct hashtable_t *vis_hash;
+ struct bcast_duplist_entry bcast_duplist[DUPLIST_SIZE];
These are 200 bytes you are adding here. Any specific reason not to allocate
it?
No specific reason, however I could not think of any reason to allocate link it:
* bat_priv is kmalloc()d anyways
* we will always need this structure once the patch is applied
* we need it only once per bat_priv, no sharing, no lists etc
* external allocation would require a few more lines plus sanity checking
no problem to change it, but I just could not think of a good reason why - maybe you
have one? :)
best regards,
Simon