On Wed, Aug 14, 2013 at 06:51:32AM -0700, Mihail Costea wrote:
On 10 August 2013 06:20, Antonio Quartulli
>> dat_entry = kmalloc(sizeof(*dat_entry), GFP_ATOMIC);
>> if (!dat_entry)
>> goto out;
>> + /* some entries don't have an extra data and useful if allocation for
>> + * data fails */
> this comment has to be indented
> /* like
> * this
> There are other style issues in this patch, but they mostly concern what I
> already pointed out in the other comments.
> Remember to always check your patch with checkpatch.pl --strict in order to find
> problems before sending the patches.
I still don't know what generated some style problems. Alignments
problems shouldn't be here because I already
used --strict (but that didn't say anything about comments) and sent
the patches with git mail. That is weird.
These are net/ specific style requirements. Try this before
sed -i "s#^--- a/#--- a/net/batman-adv/#;s#^+++ b/#+++ b/net/batman-adv/#"