Re: [B.A.T.M.A.N.] [PATCH v6 04/20] batman-adv: Convert batadv_softif_vlan to kref

On Saturday, January 16, 2016 10:29:42 Sven Eckelmann wrote:

batman-adv uses a self-written reference implementation which is just based on atomic_t. This is less obvious when reading the code than kref and therefore increases the change that the reference counting will be missed.

Signed-off-by: Sven Eckelmann sven@narfation.org

v6:

• removed patches which are now applied in the branch next
• rebased remaining patches on the patch "batman-adv: Avoid recursive call_rcu for batadv_nc_node" which was modified by Marek while he applied the patches (this unfortunately made some of the remaining patches "hard" to apply)

v5:

• add hack which allows to compile against stable kernel like 3.2.44 which also added the kref_get_unless_zero function

v4:

• fix function names in commit messages
• fix double whitespace in batadv_tt_orig_list_entry_release kerneldoc
• add extra patch for batadv_claim_free_ref kerneldoc fix
• change the phrase "free it" in all *_free_ref/*_put functions to "release

it" v3:

• update copyright year

v2:

• split patchset into fixes and kref migration to make it easier when the decision is made where each patch will be applied

net/batman-adv/soft-interface.c | 33 +++++++++++++++++++++++---------- net/batman-adv/sysfs.c | 3 ++- net/batman-adv/types.h | 2 +- 3 files changed, 26 insertions(+), 12 deletions(-)

Applied in revision 395c567.

Thanks, Marek