Re: [B.A.T.M.A.N.] [PATCH 1/6] batctl: Don't try to close negative file descriptors

On Saturday 24 May 2014 14:16:39 Sven Eckelmann wrote:

Valid file descriptors are defined as being >= 0. Error codes returned by the socket functions are defined as being < 0. This isn't checked correctly through out the code and instead 0 is used as "not valid" file descriptor.

This can lead to functions like close being called with an error code as argument.

Signed-off-by: Sven Eckelmann sven@narfation.org

functions.c | 4 ++-- ping.c | 4 ++-- tcpdump.c | 3 ++- traceroute.c | 4 ++-- 4 files changed, 8 insertions(+), 7 deletions(-)

Applied in revision 2656408.

Thanks, Marek