Re: [B.A.T.M.A.N.] [PATCH] batctl: Human readable log levels instead of bitmasks

On Monday, November 07, 2011 19:52:39 Martin Hundebøll wrote:

As the number of log levels increases, it becomes less user friendly to assign a log level, as this is given as a bitmask in decimal form. This commit changes this, so that one or more log levels can be given as human readable words (e.g. "batctl ll batman routes").

The "Signed-off-by" is missing.

• snprintf(str, 4, "%u", log_level);
  

• res = write_file(path_buff, SYS_LOG_LEVEL, str, NULL);
  

Shouldn't it be "sizeof(str)" instead of "4" and "%i" instead of "%u" ?

Regards, Marek