B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] I need some help with BATMAN configuration
by Lucy Coya 30 May '14

30 May '14

Hi everyone, My name is Lucy Coya, I´m a telecommunications engineer and I need some help with my BATMAN configuration. I´m using batman-adv-2014-2.0 and batctl-2014-2.0 I´m trying to use BATMAN protocol in a very very simple routing scenario at first to study the protocol. I have: -Two Laptops using two wireless interfaces each (wlan0 in AP mode and wlan1 in Ad Hoc mode). I meshed the two wireless interfaces in ad hoc mode according to the wiki steps and it worked fine,so I can ping the interfaces. Now I´m trying to make that two clients connected to the AP interfaces can ping each other through the mesh network. I tried creating a bridge between wlan0 and wlan1 as the wiki says but no ping :-(. I don´t know what to do so any help would be awesome!!! Thanks Sorry if my English is bad :-) Lucy 50 Aniversario de la Cujae. Inaugurada por Fidel el 2 de diciembre de 1964 http://cujae.edu.cu

3 2

[B.A.T.M.A.N.] [PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports
by Linus Lüssing 30 May '14

30 May '14

Changes in v2: * fix a nasty typo in PATCH 1/4, br_multicast_update_query_timer(): "br->multicast_query_interval" vs. "br->multicast_querier_interval" => this accidentally reduced the other querier present timer from 255 to 125 seconds * fix a typo in PATCH 2/4, br_ip{4,6}_multicast_query(): ntohs(ETH_P_{IP,IPV6}) vs. htons(ETH_P_{IP,IPV6}) * add missing ntohl()s before address comparison in PATCH 2/4, br_ip4_multicast_select_querier() (thanks David!) Cheers, Linus

3 7

[B.A.T.M.A.N.] [PATCH] alfred: Use memleak/error path free implementation of hash_resize
by Sven Eckelmann 27 May '14

27 May '14

The current implementation of hash_resize uses hash_add directly to initialize two a new hash table. But hash_add has two error cases: Data already exists and malloc fails. The check for the duplicated data is not really harmful (beside increasing the time to re-add elements) but the malloc can potentially return an error. This malloc is unnecessary and just takes extra time and is a potential candidate for errors. Instead the bucket from the old hash table can be re-used. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- hash.c | 72 ++++++++++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 44 insertions(+), 28 deletions(-) diff --git a/hash.c b/hash.c index 4b3106e..fd85a0f 100644 --- a/hash.c +++ b/hash.c @@ -63,6 +63,40 @@ void hash_delete(struct hashtable_t *hash, hashdata_free_cb free_cb) hash_destroy(hash); } +/* adds data to the hashtable and reuse bucket. + * returns 0 on success, -1 on error */ +static int hash_add_bucket(struct hashtable_t *hash, void *data, + struct element_t *bucket, int check_duplicate) +{ + int index; + struct element_t *bucket_it, *prev_bucket = NULL; + + index = hash->choose(data, hash->size); + bucket_it = hash->table[index]; + + while (bucket_it != NULL) { + if (check_duplicate && + hash->compare(bucket_it->data, data)) + return -1; + + prev_bucket = bucket_it; + bucket_it = bucket_it->next; + } + + /* init the new bucket */ + bucket->data = data; + bucket->next = NULL; + + /* and link it */ + if (prev_bucket == NULL) + hash->table[index] = bucket; + else + prev_bucket->next = bucket; + + hash->elements++; + return 0; +} + /* free only the hashtable and the hash itself. */ void hash_destroy(struct hashtable_t *hash) { @@ -186,19 +220,8 @@ struct hashtable_t *hash_new(int size, hashdata_compare_cb compare, /* adds data to the hashtable. returns 0 on success, -1 on error */ int hash_add(struct hashtable_t *hash, void *data) { - int index; - struct element_t *bucket, *prev_bucket = NULL; - - index = hash->choose(data, hash->size); - bucket = hash->table[index]; - - while (bucket != NULL) { - if (hash->compare(bucket->data, data)) - return -1; - - prev_bucket = bucket; - bucket = bucket->next; - } + int ret; + struct element_t *bucket; /* found the tail of the list, add new element */ bucket = debugMalloc(sizeof(struct element_t), 304); @@ -206,18 +229,11 @@ int hash_add(struct hashtable_t *hash, void *data) if (!bucket) return -1; - /* init the new bucket */ - bucket->data = data; - bucket->next = NULL; + ret = hash_add_bucket(hash, data, bucket, 1); + if (ret < 0) + debugFree(bucket, 1307); - /* and link it */ - if (prev_bucket == NULL) - hash->table[index] = bucket; - else - prev_bucket->next = bucket; - - hash->elements++; - return 0; + return ret; } /* finds data, based on the key in keydata. returns the found data on success, @@ -307,10 +323,10 @@ struct hashtable_t *hash_resize(struct hashtable_t *hash, int size) /* copy the elements */ for (i = 0; i < hash->size; i++) { - bucket = hash->table[i]; - while (bucket != NULL) { - hash_add(new_hash, bucket->data); - bucket = bucket->next; + while (hash->table[i]) { + bucket = hash->table[i]; + hash->table[i] = bucket->next; + hash_add_bucket(new_hash, bucket->data, bucket, 0); } } /* remove hash and eventual overflow buckets but not the -- 2.0.0.rc2

2 3

[B.A.T.M.A.N.] [PATCH] batadv-vis: Avoid file handler leak after failed realloc
by Sven Eckelmann 27 May '14

27 May '14

The read_file function opens the file and thus has to close the filehandler after an realloc error. This was forgotten in the fix 0ad384e11ed039d4c3025a7eaf19fe6bcfd41acf ("batadv-vis: Avoid memory leak after failed realloc"). Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- vis/vis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vis/vis.c b/vis/vis.c index f429942..55c2dad 100644 --- a/vis/vis.c +++ b/vis/vis.c @@ -56,6 +56,7 @@ static char *read_file(char *fname) buf_tmp = realloc(buf, size + 4097); if (!buf_tmp) { free(buf); + fclose(fp); return NULL; } -- 2.0.0.rc4

2 1

[B.A.T.M.A.N.] [PATCH 01/10] batadv-vis: Avoid memory leak after failed realloc
by Sven Eckelmann 27 May '14

27 May '14

realloc doesn't free the original buffer when the reallocation failed. An abort of read_file without free'ing the buffer would leak it. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- vis/vis.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/vis/vis.c b/vis/vis.c index 7a8e780..b51fede 100644 --- a/vis/vis.c +++ b/vis/vis.c @@ -40,7 +40,7 @@ static char *read_file(char *fname) { FILE *fp; - char *buf = NULL; + char *buf = NULL, *buf_tmp; size_t size, ret; fp = fopen(fname, "r"); @@ -51,10 +51,13 @@ static char *read_file(char *fname) size = 0; while (!feof(fp)) { - buf = realloc(buf, size + 4097); - if (!buf) + buf_tmp = realloc(buf, size + 4097); + if (!buf_tmp) { + free(buf); return NULL; + } + buf = buf_tmp; ret = fread(buf + size, 1, 4096, fp); size += ret; } -- 2.0.0.rc2

3 11

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Restrict movement of batman interfaces between netns.
by Daniel Ehlers 26 May '14

26 May '14

We shall _not_ move composed interfaces between network namespaces. Should fix issue #179, though I only tested it in a pure netns enviroment and not in a more complex lxc setup. Signed-off-by: Daniel Ehlers <danielehlers(a)mindeye.net> --- soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/soft-interface.c b/soft-interface.c index e783afb..dcaf02b 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -909,7 +909,7 @@ static void batadv_softif_init_early(struct net_device *dev) dev->netdev_ops = &batadv_netdev_ops; dev->destructor = batadv_softif_free; - dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER; + dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL; dev->tx_queue_len = 0; /* can't call min_mtu, because the needed variables -- 1.9.2

1 0

[B.A.T.M.A.N.] bridge: multicast snooping patches / exports
by Linus Lüssing 24 May '14

24 May '14

Hi, The first patch is simply a cosmetic patch. So far I (and maybe others too?) have been regularly confusing these two structs, therefore I'd suggest renaming them and therefore making the follow-up patches easier to understand and nicer to fit in. The second patch fixes a minor issue, but probably not worth for stable. On the other hand the first two patches are also preparations for the third and fourth patch: These two patches are exporting functionality needed to marry the bridge multicast snooping with the batman-adv multicast optimizations recently added for the 3.15 kernel, allowing to use these optimzations in common setups having a bridge on top of e.g. bat0, too. So far these bridged setups would fall back to simple flooding through the batman-adv mesh network for any multicast packet entering bat0. More information about the batman-adv multicast optimizations currently implemented can be found here: http://www.open-mesh.org/projects/batman-adv/wiki/Basic-multicast-optimizat… The integration on the batman-adv side could afterwards look like this, for instance: http://git.open-mesh.org/batman-adv.git/commitdiff/576b59dd3e34737c702e548b… Cheers, Linus

2 6

Re: [B.A.T.M.A.N.] BATMAN-ADV emulated in DCE module of ns-3
by Krishnathiepan Rasanayagam 23 May '14

23 May '14

hello, I dint get the meaning of the message. did you developed a framework of batman-adv on ns-3? or something else? regards, krishna On Tue, May 20, 2014 at 10:10 PM, Krishnathiepan Rasanayagam <r.krishnathiepan(a)gmail.com> wrote: > hello, > I dint get the meaning of the message. did you developed a framework of > batman-adv on ns-3? or something else? > > regards, > krishna -- Best regards, Krishna.

4 4

[B.A.T.M.A.N.] Adding security on BATMAN-ADV
by Krishnathiepan Rasanayagam 22 May '14

22 May '14

Hello all, I'm researching on batman-adv about adding security on node authentication. I'm trying to integrate threshold cryptography in BATMAN-ADV. Does anyone have worked in that area? or similar researches have been done on it? Please let me know. -- Best regards, Krishna.

2 6

[B.A.T.M.A.N.] BATMAN-ADV security
by Krishnathiepan Rasanayagam 21 May '14

21 May '14

Does batman-adv has any special features regarding security . in terms of authentication or encryption etc -- Best regards, Krishna.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N