B.A.T.M.A.N October 2015

b.a.t.m.a.n@lists.open-mesh.org

12 participants
27 discussions

[B.A.T.M.A.N.] [PATCH] batman-adv: fix debuginfo macro style issue
by Simon Wunderlich 10 Mar '16

10 Mar '16

From: Simon Wunderlich <simon(a)open-mesh.com> Structure initialization within the macros should follow the general coding style used in the kernel: put the initialization of the first variable and the closing brace on a separate line. Reported-by: Antonio Quartulli <antonio(a)meshcoding.com> Signed-off-by: Simon Wunderlich <simon(a)open-mesh.com> --- debugfs.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/debugfs.c b/debugfs.c index cd5d24a..92d9d83 100644 --- a/debugfs.c +++ b/debugfs.c @@ -322,14 +322,17 @@ static int batadv_nc_nodes_open(struct inode *inode, struct file *file) #define BATADV_DEBUGINFO(_name, _mode, _open) \ struct batadv_debuginfo batadv_debuginfo_##_name = { \ - .attr = { .name = __stringify(_name), \ - .mode = _mode, }, \ - .fops = { .owner = THIS_MODULE, \ - .open = _open, \ - .read = seq_read, \ - .llseek = seq_lseek, \ - .release = single_release, \ - } \ + .attr = { \ + .name = __stringify(_name), \ + .mode = _mode, \ + }, \ + .fops = { \ + .owner = THIS_MODULE, \ + .open = _open, \ + .read = seq_read, \ + .llseek = seq_lseek, \ + .release = single_release, \ + }, \ }; /* the following attributes are general and therefore they will be directly -- 1.7.10.4

2 1

[B.A.T.M.A.N.] [PATCH next] batman-adv: fix DAT candidate selection (must use vid)
by Antonio Quartulli 10 Mar '16

10 Mar '16

Now that DAT is VLAN aware, it must use the VID when computing the DHT address of the candidate nodes where an entry is going to be stored/retrieved. Introduced by: 3e26722bc9f248ec4316749fc1957365c0fa5e4b ("batman-adv: make the Distributed ARP Table vlan aware") Signed-off-by: Antonio Quartulli <antonio(a)meshcoding.com> --- distributed-arp-table.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/distributed-arp-table.c b/distributed-arp-table.c index 6c8c393..d4b3940 100644 --- a/distributed-arp-table.c +++ b/distributed-arp-table.c @@ -530,11 +530,13 @@ static void batadv_choose_next_candidate(struct batadv_priv *bat_priv, * Returns the candidate array of size BATADV_DAT_CANDIDATE_NUM. */ static struct batadv_dat_candidate * -batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst) +batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst, + unsigned short vid) { int select; batadv_dat_addr_t last_max = BATADV_DAT_ADDR_MAX, ip_key; struct batadv_dat_candidate *res; + struct batadv_dat_entry to_hash; if (!bat_priv->orig_hash) return NULL; @@ -543,7 +545,10 @@ batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst) if (!res) return NULL; - ip_key = (batadv_dat_addr_t)batadv_hash_dat(&ip_dst, + to_hash.ip = ip_dst; + to_hash.vid = vid; + + ip_key = (batadv_dat_addr_t)batadv_hash_dat(&to_hash, BATADV_DAT_ADDR_MAX); batadv_dbg(BATADV_DBG_DAT, bat_priv, @@ -572,7 +577,7 @@ batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst) */ static bool batadv_dat_send_data(struct batadv_priv *bat_priv, struct sk_buff *skb, __be32 ip, - int packet_subtype) + unsigned short vid, int packet_subtype) { int i; bool ret = false; @@ -581,7 +586,7 @@ static bool batadv_dat_send_data(struct batadv_priv *bat_priv, struct sk_buff *tmp_skb; struct batadv_dat_candidate *cand; - cand = batadv_dat_select_candidates(bat_priv, ip); + cand = batadv_dat_select_candidates(bat_priv, ip, vid); if (!cand) goto out; @@ -969,7 +974,7 @@ bool batadv_dat_snoop_outgoing_arp_request(struct batadv_priv *bat_priv, ret = true; } else { /* Send the request to the DHT */ - ret = batadv_dat_send_data(bat_priv, skb, ip_dst, + ret = batadv_dat_send_data(bat_priv, skb, ip_dst, vid, BATADV_P_DAT_DHT_GET); } out: @@ -1092,8 +1097,8 @@ void batadv_dat_snoop_outgoing_arp_reply(struct batadv_priv *bat_priv, /* Send the ARP reply to the candidates for both the IP addresses that * the node obtained from the ARP reply */ - batadv_dat_send_data(bat_priv, skb, ip_src, BATADV_P_DAT_DHT_PUT); - batadv_dat_send_data(bat_priv, skb, ip_dst, BATADV_P_DAT_DHT_PUT); + batadv_dat_send_data(bat_priv, skb, ip_src, vid, BATADV_P_DAT_DHT_PUT); + batadv_dat_send_data(bat_priv, skb, ip_dst, vid, BATADV_P_DAT_DHT_PUT); } /** * batadv_dat_snoop_incoming_arp_reply - snoop the ARP reply and fill the local -- 1.8.1.5

3 2

[B.A.T.M.A.N.] old batman-adv within 15.05 brunch?
by Ufo 10 Dec '15

10 Dec '15

is there a reason for staying with batman-adv 2014 for openwrt 15.05? our current freifunk leipzig running batman-adv 2015.0 and it seems to work https://github.com/openwrt-routing/packages/tree/master/batman-adv vs. https://github.com/openwrt-routing/packages/tree/for-15.05/batman-adv -- --- Freifunk Leipzig http://leipzig.freifunk.net

3 3

[B.A.T.M.A.N.] [PATCH v2] batman-adv: Change ifconfig examples to iproute2
by Sven Eckelmann 17 Nov '15

17 Nov '15

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- v2: fixed "NodeA" in NodeB block Documentation/networking/batman-adv.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/batman-adv.txt b/Documentation/networking/batman-adv.txt index 58e4904..ff23b75 100644 --- a/Documentation/networking/batman-adv.txt +++ b/Documentation/networking/batman-adv.txt @@ -115,14 +115,17 @@ The "bat0" interface can be used like any other regular inter- face. It needs an IP address which can be either statically con- figured or dynamically (by using DHCP or similar services): -# NodeA: ifconfig bat0 192.168.0.1 -# NodeB: ifconfig bat0 192.168.0.2 +# NodeA: ip link set up dev bat0 +# NodeA: ip addr add 192.168.0.1/24 dev bat0 + +# NodeB: ip link set up dev bat0 +# NodeB: ip addr add 192.168.0.2/24 dev bat0 # NodeB: ping 192.168.0.1 Note: In order to avoid problems remove all IP addresses previ- ously assigned to interfaces now used by batman advanced, e.g. -# ifconfig eth0 0.0.0.0 +# ip addr flush dev eth0 LOGGING/DEBUGGING -- 2.6.2

2 1

[B.A.T.M.A.N.] [PATCH 0/2] Kerneldoc fixes and TODOs
by Sven Eckelmann 17 Nov '15

17 Nov '15

Hi, since a month the daily build_test is reporting the problems [1] with the kerneldoc which I reported and started to fix two months ago [2]. Unfortunately, no new patches were send until now. I have prepared now two patches for the main functions and the network coding part of batman-adv. The TODOs (and also partially fixed TODOs) of the remaining three parts (BLA, DAT, TT) can be found in the attachments of this mail. Kind regards, Sven [1] https://lists.open-mesh.org/pipermail/linux-merge/2015-October/002635.html [2] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-September/013653.html

3 7

[B.A.T.M.A.N.] Classes and purposed classes (problem to solve)
by cmsv 16 Nov '15

16 Nov '15

Scenario: I have recently moved 13 nodes previously using wds to batman-adv. One problem that i am encountering is the gateway selection and its actually defectiveness. This problem has be seen when the client nodes are set on class 20. The node clients in fact select the gateways that advertise better link quality usually above 200 but at the same time some clients end up connecting to a gateway that is either too slow or unusable either due to routing or other factors such as distance and even clear visibility. In one case the node connects to something that defies logic. I thought about ways to work around this and came up with an idea that may help which means the creation of 2 new classes. - Preferred gateway fall-back - Preferred fixed gateway For Preferred gateway fall-back: consider the gateway's advertised quality towards the gateway and stick with the selection until the gateway disappears returning to it soon as it returns regardless of any other data. - Preferred fixed gateway Manual gateway selection by the node owner or admin. (wds type) If these classes cannot be created; maybe a plugin of some sort could be. could be called "gordon". I understand that this idea may sound useless the same way blocking originators may be for someone but in some scenarios just like blocking originators it look to me very valid. My current problem is that the link quality seems to go up and down like a roller coaster in a specific order which causes the clients to switch constantly sometimes many times per hour. While this does not seem to be an issue for most client nodes; for 2 of them it means no internet access at all. The solution for now seems to be having these 2 nodes forced to use 1 specific gateway. I am quite open to any ideas that may help resolve this issue that has been casing some "uninformed people" to become headaches. -- Redes wireless http://wirelesspt.net

3 2

[B.A.T.M.A.N.] Missing patches in net-next
by Sven Eckelmann 31 Oct '15

31 Oct '15

Hi, there are some patches waiting in batman-adv's next branch which are currently missing in davem's net-next. The diff from the daily build_test is stable since 1 1/2 months [1]: net/batman-adv/bridge_loop_avoidance.c | 35 +++--------------------- net/batman-adv/routing.c | 19 ++----------- net/batman-adv/translation-table.c | 24 ++-------------- net/batman-adv/types.h | 2 - 4 files changed, 12 insertions(+), 68 deletions(-) The patches which are currently missing in net-next are: 2decb5f1fef1484f1b7319aaf2f36b5492d8d943 4a73d7438dfb60c7ac82758875292bc14f363b45 2dd1d9f06ac1208b1921aa90d479c3940bc70b4f b307e72d119f0ca5cf3c00d05d62320975261ef4 All of them are from maint and thus have conflicts with patches that are already in net-next. The rebased/squashed patches can be found in the attachments. Kind regards, Sven [1] https://lists.open-mesh.org/pipermail/linux-merge/2015-September/002582.html

1 0

[B.A.T.M.A.N.] [RFC] batman-adv: Fix invalid stack access in batadv_dat_select_candidates
by Sven Eckelmann 28 Oct '15

28 Oct '15

From: Sven Eckelmann <sven(a)open-mesh.com> batadv_dat_select_candidates provides an u32 to batadv_hash_dat but it needs a batadv_dat_entry with at least ip and vid filled in. Signed-off-by: Sven Eckelmann <sven(a)open-mesh.com> Cc: Antonio Quartulli <antonio(a)open-mesh.com> --- distributed-arp-table.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/distributed-arp-table.c b/distributed-arp-table.c index b9efeba..935af1e 100644 --- a/net/batman-adv/distributed-arp-table.c +++ b/net/batman-adv/distributed-arp-table.c @@ -533,6 +533,7 @@ batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst) int select; batadv_dat_addr_t last_max = BATADV_DAT_ADDR_MAX, ip_key; struct batadv_dat_candidate *res; + struct batadv_dat_entry dat; if (!bat_priv->orig_hash) return NULL; @@ -541,7 +542,9 @@ batadv_dat_select_candidates(struct batadv_priv *bat_priv, __be32 ip_dst) if (!res) return NULL; - ip_key = (batadv_dat_addr_t)batadv_hash_dat(&ip_dst, + dat.ip = ip_dst; + dat.vid = 0; + ip_key = (batadv_dat_addr_t)batadv_hash_dat(&dat, BATADV_DAT_ADDR_MAX); batadv_dbg(BATADV_DBG_DAT, bat_priv,

2 1

[B.A.T.M.A.N.] Alfred GPS higher update rate
by Keith Chew 22 Oct '15

22 Oct '15

Hi I am experimenting with using Alfred on a group of drones (initially 10 units) to send their GPS locations to each other. The drones will be connected via batman-adv on WIFI, and each of them read the GPS every 200ms (5Hz). I would like to change alfred-gpsd from updating the GPS coordinates every 10s to 200ms. Does anyone see any issues with this change? ie it is even feasible/practical? Regards Keith

2 3

[B.A.T.M.A.N.] video streaming over batman-adv
by Santiago Álvarez Álvarez 19 Oct '15

19 Oct '15

Hi everybody, Im an engineer working in a R&D Project using batman-adv protocol. Were trying to develop a mesh network using linux devices with the objective of transmitting video in streaming. Video is being generated with gstreamer using UDP. The application works relatively fine with 2 devices, but efficiency heavily decreases when introducing a new node in the mesh network (information need two jumps to arrive to destination). Introducing more jumps in the network is exponentially worst. We have been expecting a better behavior of this protocol, since level 2 routing should be transparent (just increasing delay when increasing the number of nodes). We are using batman version 2015.0, over wifi interfaces, and our streaming applications is working only point-to-point (not multicast or broadcast). The nodes in between server and client are working just as wireless repeaters using batman-adv. We also discovered that worst case happens when changes in batman routing tables are happening (sometimes, client is able to reach server in just one jump, but with low quality, and chooses that option instead of jumping through the repeater node, with better quality). When that happens, we're droping lots of packets. Any of you haver tried batman-adv for video streaming? Which was the maximum number of jumps between batman nodes that you can manage maintaining a good video quality? Can you recommend any specific configuration for improving batman behavior?

3 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N October 2015