From: Simon Wunderlich <simon(a)open-mesh.com>
Structure initialization within the macros should follow the general
coding style used in the kernel: put the initialization of the first
variable and the closing brace on a separate line.
Reported-by: Antonio Quartulli <antonio(a)meshcoding.com>
Signed-off-by: Simon Wunderlich <simon(a)open-mesh.com>
---
debugfs.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/debugfs.c b/debugfs.c
index cd5d24a..92d9d83 100644
--- a/debugfs.c
+++ b/debugfs.c
@@ -322,14 +322,17 @@ static int batadv_nc_nodes_open(struct inode *inode, struct file
*file)
#define BATADV_DEBUGINFO(_name, _mode, _open) \
struct batadv_debuginfo batadv_debuginfo_##_name = { \
- .attr = { .name = __stringify(_name), \
- .mode = _mode, }, \
- .fops = { .owner = THIS_MODULE, \
- .open = _open, \
- .read = seq_read, \
- .llseek = seq_lseek, \
- .release = single_release, \
- } \
+ .attr = { \
+ .name = __stringify(_name), \
+ .mode = _mode, \
+ }, \
+ .fops = { \
+ .owner = THIS_MODULE, \
+ .open = _open, \
+ .read = seq_read, \
+ .llseek = seq_lseek, \
+ .release = single_release, \
+ }, \
};
/* the following attributes are general and therefore they will be directly
--
1.7.10.4
Show replies by date
On Thursday 21 November 2013 14:17:45 Simon Wunderlich wrote:
From: Simon Wunderlich <simon(a)open-mesh.com>
Structure initialization within the macros should follow the general
coding style used in the kernel: put the initialization of the first
variable and the closing brace on a separate line.
Reported-by: Antonio Quartulli <antonio(a)meshcoding.com>
Signed-off-by: Simon Wunderlich <simon(a)open-mesh.com>
---
It looks like this patch doesn't apply anymore. Can you please resent it or
mark it correctly in patchwork [1].
But for the cleanup:
Acked-by: Sven Eckelmann <sven(a)narfation.org>
Thanks,
Sven
[1]
https://patchwork.open-mesh.org/patch/3668/