B.A.T.M.A.N April 2014

b.a.t.m.a.n@lists.open-mesh.org

20 participants
33 discussions

[B.A.T.M.A.N.] [PATCH 1/7] cfg80211: export expected throughput through get_station()

by Antonio Quartulli

From: Antonio Quartulli <antonio(a)open-mesh.com> Users may need information about the expected throughput towards a given peer computed by the RC algorithm. Export such value in Mbps/100 through the get_station() API. This unit has been chosen because it is the same of the throughput returned by MinstrelHT. This information will be useful to the batman-adv module which will use it for its new metric computation. Signed-off-by: Antonio Quartulli <antonio(a)open-mesh.com> --- Changes since the RFC: - Change all the station_info_flags to use BIT() - Properly comment about the unit used by the throughput value - added new ieee80211_ops.get_expected_throughput() API (to support drivers having HW RC) - improved doc about new cfg80211_get_station() function - minor cleanups include/net/cfg80211.h | 63 ++++++++++++++++++++++++++++---------------------- 1 file changed, 35 insertions(+), 28 deletions(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 9496fe5..d4b85f7 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -862,36 +862,38 @@ int cfg80211_check_station_change(struct wiphy *wiphy, * @STATION_INFO_NONPEER_PM: @nonpeer_pm filled * @STATION_INFO_CHAIN_SIGNAL: @chain_signal filled * @STATION_INFO_CHAIN_SIGNAL_AVG: @chain_signal_avg filled + * @STATION_INFO_EXPECTED_THROUGHPUT: @expected_throughput filled */ enum station_info_flags { - STATION_INFO_INACTIVE_TIME = 1<<0, - STATION_INFO_RX_BYTES = 1<<1, - STATION_INFO_TX_BYTES = 1<<2, - STATION_INFO_LLID = 1<<3, - STATION_INFO_PLID = 1<<4, - STATION_INFO_PLINK_STATE = 1<<5, - STATION_INFO_SIGNAL = 1<<6, - STATION_INFO_TX_BITRATE = 1<<7, - STATION_INFO_RX_PACKETS = 1<<8, - STATION_INFO_TX_PACKETS = 1<<9, - STATION_INFO_TX_RETRIES = 1<<10, - STATION_INFO_TX_FAILED = 1<<11, - STATION_INFO_RX_DROP_MISC = 1<<12, - STATION_INFO_SIGNAL_AVG = 1<<13, - STATION_INFO_RX_BITRATE = 1<<14, - STATION_INFO_BSS_PARAM = 1<<15, - STATION_INFO_CONNECTED_TIME = 1<<16, - STATION_INFO_ASSOC_REQ_IES = 1<<17, - STATION_INFO_STA_FLAGS = 1<<18, - STATION_INFO_BEACON_LOSS_COUNT = 1<<19, - STATION_INFO_T_OFFSET = 1<<20, - STATION_INFO_LOCAL_PM = 1<<21, - STATION_INFO_PEER_PM = 1<<22, - STATION_INFO_NONPEER_PM = 1<<23, - STATION_INFO_RX_BYTES64 = 1<<24, - STATION_INFO_TX_BYTES64 = 1<<25, - STATION_INFO_CHAIN_SIGNAL = 1<<26, - STATION_INFO_CHAIN_SIGNAL_AVG = 1<<27, + STATION_INFO_INACTIVE_TIME = BIT(0), + STATION_INFO_RX_BYTES = BIT(1), + STATION_INFO_TX_BYTES = BIT(2), + STATION_INFO_LLID = BIT(3), + STATION_INFO_PLID = BIT(4), + STATION_INFO_PLINK_STATE = BIT(5), + STATION_INFO_SIGNAL = BIT(6), + STATION_INFO_TX_BITRATE = BIT(7), + STATION_INFO_RX_PACKETS = BIT(8), + STATION_INFO_TX_PACKETS = BIT(9), + STATION_INFO_TX_RETRIES = BIT(10), + STATION_INFO_TX_FAILED = BIT(11), + STATION_INFO_RX_DROP_MISC = BIT(12), + STATION_INFO_SIGNAL_AVG = BIT(13), + STATION_INFO_RX_BITRATE = BIT(14), + STATION_INFO_BSS_PARAM = BIT(15), + STATION_INFO_CONNECTED_TIME = BIT(16), + STATION_INFO_ASSOC_REQ_IES = BIT(17), + STATION_INFO_STA_FLAGS = BIT(18), + STATION_INFO_BEACON_LOSS_COUNT = BIT(19), + STATION_INFO_T_OFFSET = BIT(20), + STATION_INFO_LOCAL_PM = BIT(21), + STATION_INFO_PEER_PM = BIT(22), + STATION_INFO_NONPEER_PM = BIT(23), + STATION_INFO_RX_BYTES64 = BIT(24), + STATION_INFO_TX_BYTES64 = BIT(25), + STATION_INFO_CHAIN_SIGNAL = BIT(26), + STATION_INFO_CHAIN_SIGNAL_AVG = BIT(27), + STATION_INFO_EXPECTED_THROUGHPUT = BIT(28), }; /** @@ -1013,6 +1015,9 @@ struct sta_bss_parameters { * @local_pm: local mesh STA power save mode * @peer_pm: peer mesh STA power save mode * @nonpeer_pm: non-peer mesh STA power save mode + * @expected_throughput: expected throughput in Mbps/100 reported by the RC + * algorithm towards this station. The unit of this value has been chosen + * because it is the same of the throughput returned by MinstrelHT */ struct station_info { u32 filled; @@ -1051,6 +1056,8 @@ struct station_info { enum nl80211_mesh_power_mode peer_pm; enum nl80211_mesh_power_mode nonpeer_pm; + u32 expected_throughput; + /* * Note: Add a new enum station_info_flags value for each new field and * use it to check which fields are initialized. -- 1.8.3.2

8 years, 10 months

Re: [B.A.T.M.A.N.] batctl oops on batctl gateways call

by Fabrice Dossin

Hi, I could not reproduce this. I keep you update if I see this again. Best regards, Fabrice On 3 April 2014 10:21, Fabrice Dossin <fabrice.dossin(a)gmail.com> wrote: > (Sorry, reformatting again, leaving text mode) > > > Hi, > > Sorry, my mail client did this behind my back. I did resend the stack > here under for readability. > > For now, it has append only one time on one node. This particular node > does not have any other node in his range. I execute a "batctl > gateways" each 5 minutes for monitoring. I will let you know if it > appends again today or if I found information for reproducibility. > > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.500226] Unable to handle kernel > NULL pointer dereference at virtual address 00000022 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.508175] pgd = d4918000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.514355] [00000022] *pgd=138f9831, > *pte=00000000, *ppte=00000000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.521733] Internal error: Oops: 17 > [#5] PREEMPT ARM > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.527131] Modules linked in: tun > ipt_MASQUERADE iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 > nf_nat nf_conntrack iptable_filter ip_tables x_tables ipv6 bcm2708_rng > bcm2708_wdog batman_adv(O) rtc_ds1307 qmi_wwan option usb_wwan arc4 > usbserial cdc_wdm rt2800usb rt2800lib rt2x00usb rt2x00lib mac80211 cfg80211 > crc_ccitt sr_mod cdrom leds_gpio led_class rt5572sta(O) spi_bcm2708 > i2c_bcm2708 btusb bluetooth rfkill > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.544610] CPU: 0 PID: 7261 Comm: > batctl Tainted: G D O 3.10.30+ #1 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.550263] task: d49f3180 ti: d38d0000 > task.ti: d38d0000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.556017] PC is at > batadv_orig_router_get+0x50/0x9c [batman_adv] > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.561587] LR is at > batadv_orig_router_get+0x10/0x9c [batman_adv] > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.566974] pc : [<bf35e218>] lr : > [<bf35e1d8>] psr: 20000013 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.566974] sp : d38d1ea8 ip : > 0000000a fp : dda60600 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.577350] r10: cccccccd r9 : > ddab7000 r8 : dda60600 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.582439] r7 : 00000000 r6 : > 00000000 r5 : d4826e00 r4 : 00000000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.587535] r3 : d4ac0000 r2 : > 00000000 r1 : 00000000 r0 : 00000002 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.592468] Flags: nzCv IRQs on FIQs > on Mode SVC_32 ISA ARM Segment user > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.597357] Control: 00c5387d Table: > 14918008 DAC: 00000015 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.602319] Process batctl (pid: 7261, > stack limit = 0xd38d01b0) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.607230] Stack: (0xd38d1ea8 to > 0xd38d2000) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.611903] 1ea0: > d49f3180 d49c2580 00000000 bf35a62c 000000ff bf368ed8 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.616816] 1ec0: bf368ee0 bf368eec > dc89b000 dbe3cd08 ddab7000 dc83bba0 dbd10900 00000000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.621720] 1ee0: 00100073 00000000 > d25a0aa0 00000000 00000000 00000001 d38d1f20 00000001 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.626477] 1f00: dda60600 c00f653c > d1f20790 d38d1f80 00001000 b6f18000 dda60628 00000000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.631263] 1f20: 00000000 00000000 > 00001000 dc83bba0 00000001 d25a0aa0 b6f18000 d38d0000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.636092] 1f40: d38d1f80 00001000 > d38d0000 00001000 bea8eb54 c00d7530 00000000 00000003 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.640834] 1f60: 00000000 00000000 > 00000000 d25a0aa0 b6f18000 00000000 00001000 c00d77c4 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.645450] 1f80: 00000000 00000000 > ffffffff 00916008 fbad2488 00000000 00000003 c000dd68 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.650123] 1fa0: 00000000 c000dbc0 > 00916008 fbad2488 00000003 b6f18000 00001000 00000000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.654758] 1fc0: 00916008 fbad2488 > 00000000 00000003 00000000 00021450 b6f1f000 bea8eb54 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.659333] 1fe0: 00000000 bea8e8c8 > b6d945f8 b6de52bc 60000010 00000003 00000000 00000000 > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.664121] [<bf35e218>] > (batadv_orig_router_get+0x50/0x9c [batman_adv]) from [<bf35a62c>] > (batadv_gw_client_seq_print_text+0xac/0x220 [batman_adv]) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.673531] [<bf35a62c>] > (batadv_gw_client_seq_print_text+0xac/0x220 [batman_adv]) from [<c00f653c>] > (seq_read+0x1d0/0x4cc) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.678287] [<c00f653c>] > (seq_read+0x1d0/0x4cc) from [<c00d7530>] (vfs_read+0x98/0x17c) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.683071] [<c00d7530>] > (vfs_read+0x98/0x17c) from [<c00d77c4>] (SyS_read+0x3c/0x70) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.687982] [<c00d77c4>] > (SyS_read+0x3c/0x70) from [<c000dbc0>] (ret_fast_syscall+0x0/0x30) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.692822] Code: e8bd8038 e593000c > e3500000 0afffff8 (e5902020) > Apr 2 11:45:08 pv2-1dnci kernel: [ 7432.718781] ---[ end trace > 1e5ba977f5516301 ]--- > > Regards, > Fabrice > >> >>> Hi Fabrice, >>> >>> On 02/04/14 13:50, Fabrice Dossin wrote: >>>> Dear all, >>>> >>>> Hello. >>>> I am not sure it has been notified so I post this issue here. >>>> It is my first post, so tell me if I do it bad... >>>> >>> >>> no problem, it's fine! Maybe sending the stack trace without adding new >>> lines is better, but this is fine anyway :) >>> >>> Are you able to reproduce this problem somehow? Or it happened only once >>> under no particular conditions? >>> >>> Cheers, >>> >>> >>> -- >>> Antonio Quartulli >>> >

8 years, 10 months

[B.A.T.M.A.N.] [PATCH 1/2] alfred: Handle EPERM on every sendto

by Sven Eckelmann

The announcements are currently only sent by alfred instances in master mode. Slave instances don't announce themself and thus don't detect the broken socket. To also catch such problems, it is useful to handle the detection of EPERM during the send in send_alfred_packet which is always called when a link-local UDP packet is send over the network. Signed-off-by: Sven Eckelmann <sven(a)open-mesh.com> --- send.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/send.c b/send.c index 89e9c07..dc0e428 100644 --- a/send.c +++ b/send.c @@ -32,7 +32,6 @@ int announce_master(struct globals *globals) { - ssize_t ret; struct alfred_announce_master_v0 announcement; if (globals->netsock < 0) @@ -42,14 +41,8 @@ int announce_master(struct globals *globals) announcement.header.version = ALFRED_VERSION; announcement.header.length = htons(0); - ret = send_alfred_packet(globals, &in6addr_localmcast, &announcement, - sizeof(announcement)); - if (ret == -EPERM) { - fprintf(stderr, "Error during announcement\n"); - netsock_close(globals->netsock); - globals->netsock = -1; - } - + send_alfred_packet(globals, &in6addr_localmcast, &announcement, + sizeof(announcement)); return 0; } @@ -176,6 +169,11 @@ ssize_t send_alfred_packet(struct globals *globals, const struct in6_addr *dest, ret = sendto(globals->netsock, buf, length, 0, (struct sockaddr *)&dest_addr, sizeof(struct sockaddr_in6)); + if (ret == -EPERM) { + fprintf(stderr, "Error during sent\n"); + netsock_close(globals->netsock); + globals->netsock = -1; + } return ret; } -- 1.9.2

8 years, 10 months

[B.A.T.M.A.N.] [PATCHv3 1/2] batctl: add switch for setting multicast_mode

by Linus Lüssing

This patch adds a switch for the new multicast_mode setting in batman-adv. Signed-off-by: Linus Lüssing <linus.luessing(a)web.de> --- v3: fix merge conflict (ordex was quicker with his isolation mark support patch :P) README | 7 +++++++ man/batctl.8 | 4 ++++ sys.c | 6 ++++++ sys.h | 1 + 4 files changed, 18 insertions(+) diff --git a/README b/README index a4507b7..fe8eed9 100644 --- a/README +++ b/README @@ -392,6 +392,13 @@ Usage: batctl network_coding|nc [0|1] Note that network coding requires a working promiscuous mode on all interfaces. +batctl multicast_mode +===================== + +display or modify the multicast mode setting + +Usage: batctl multicast_mode|mm [0|1] + batctl aggregation ================== diff --git a/man/batctl.8 b/man/batctl.8 index b808293..f92bf3a 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -88,6 +88,10 @@ disable fragmentation. If no parameter is given the current network coding mode setting is displayed. Otherwise the parameter is used to enable or disable network coding. .br +.IP "\fBmulticast_mode\fP|\fBmm\fP [\fB0\fP|\fB1\fP]" +If no parameter is given the current multicast mode setting is displayed. Otherwise the parameter is used to enable or +disable multicast optimizations (i.e. disabling means always sending own multicast frames via classic flooding). +.br .IP "\fBloglevel\fP|\fBll\fP [\fBlevel\fP[ \fBlevel\fP[ \fBlevel\fP]] \fB...\fP]" If no parameter is given the current log level settings are displayed otherwise the parameter(s) is/are used to set the log level. Level 'none' disables all verbose logging. Level 'batman' enables messages related to routing / flooding / broadcasting. diff --git a/sys.c b/sys.c index fd6e107..d20696b 100644 --- a/sys.c +++ b/sys.c @@ -103,6 +103,12 @@ const struct settings_data batctl_settings[BATCTL_SETTINGS_NUM] = { .sysfs_name = "isolation_mark", .params = NULL, }, + { + .opt_long = "multicast_mode", + .opt_short = "mm", + .sysfs_name = "multicast_mode", + .params = sysfs_param_enable, + }, }; static void interface_usage(void) diff --git a/sys.h b/sys.h index 5633822..dd0bee5 100644 --- a/sys.h +++ b/sys.h @@ -47,6 +47,7 @@ enum batctl_settings_list { BATCTL_SETTINGS_FRAGMENTATION, BATCTL_SETTINGS_NETWORK_CODING, BATCTL_SETTINGS_ISOLATION_MARK, + BATCTL_SETTINGS_MULTICAST_MODE, BATCTL_SETTINGS_NUM, }; -- 1.7.10.4

8 years, 10 months

[B.A.T.M.A.N.] [PATCH maint] batman-adv: fix reference counting imbalance while sending fragment

by Antonio Quartulli

From: Antonio Quartulli <antonio(a)open-mesh.com> In the new fragmentation code the batadv_frag_send_packet() function obtains a reference to the primary_if, but it does not release it upon return. This reference imbalance prevents the primary_if (and then the related netdevice) to be properly released on shut down. Fix this by releasing the primary_if in batadv_frag_send_packet(). Introduced by db56e4ecf5c2b179a0101138eacc2ec52b6ef45d ("batman-adv: Fragment and send skbs larger than mtu") Cc: Martin Hundebøll <martin(a)hundeboll.net> Signed-off-by: Antonio Quartulli <antonio(a)open-mesh.com> --- fragmentation.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fragmentation.c b/fragmentation.c index 88df9b1..cc1cfd6 100644 --- a/fragmentation.c +++ b/fragmentation.c @@ -418,12 +418,13 @@ bool batadv_frag_send_packet(struct sk_buff *skb, struct batadv_neigh_node *neigh_node) { struct batadv_priv *bat_priv; - struct batadv_hard_iface *primary_if; + struct batadv_hard_iface *primary_if = NULL; struct batadv_frag_packet frag_header; struct sk_buff *skb_fragment; unsigned mtu = neigh_node->if_incoming->net_dev->mtu; unsigned header_size = sizeof(frag_header); unsigned max_fragment_size, max_packet_size; + bool ret = false; /* To avoid merge and refragmentation at next-hops we never send * fragments larger than BATADV_FRAG_MAX_FRAG_SIZE @@ -483,7 +484,11 @@ bool batadv_frag_send_packet(struct sk_buff *skb, skb->len + ETH_HLEN); batadv_send_skb_packet(skb, neigh_node->if_incoming, neigh_node->addr); - return true; + ret = true; + out_err: - return false; + if (primary_if) + batadv_hardif_free_ref(primary_if); + + return ret; } -- 1.8.3.2

8 years, 10 months

[B.A.T.M.A.N.] [PATCHv2 next] batman-adv: fix NULL pointer dereferences

by Marek Lindner

Reported-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- Changes from v1: - add next branch indication multicast.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/multicast.c b/multicast.c index 8c7ca81..96b66fd 100644 --- a/multicast.c +++ b/multicast.c @@ -415,7 +415,7 @@ batadv_mcast_forw_ipv4_node_get(struct batadv_priv *bat_priv) hlist_for_each_entry_rcu(tmp_orig_node, &bat_priv->mcast.want_all_ipv4_list, mcast_want_all_ipv4_node) { - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!atomic_inc_not_zero(&tmp_orig_node->refcount)) continue; orig_node = tmp_orig_node; @@ -442,7 +442,7 @@ batadv_mcast_forw_ipv6_node_get(struct batadv_priv *bat_priv) hlist_for_each_entry_rcu(tmp_orig_node, &bat_priv->mcast.want_all_ipv6_list, mcast_want_all_ipv6_node) { - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!atomic_inc_not_zero(&tmp_orig_node->refcount)) continue; orig_node = tmp_orig_node; @@ -493,7 +493,7 @@ batadv_mcast_forw_unsnoop_node_get(struct batadv_priv *bat_priv) hlist_for_each_entry_rcu(tmp_orig_node, &bat_priv->mcast.want_all_unsnoopables_list, mcast_want_all_unsnoopables_node) { - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!atomic_inc_not_zero(&tmp_orig_node->refcount)) continue; orig_node = tmp_orig_node; -- 2.0.0.rc0

8 years, 10 months

[B.A.T.M.A.N.] [PATCH maint] batman-adv: fix indirect hard_iface NULL dereference

by Marek Lindner

If hard_iface is NULL and goto out is made batadv_hardif_free_ref() doesn't check for NULL before dereferencing it to get to refcount. Reported-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- originator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/originator.c b/originator.c index aa2468b..35b42f8 100644 --- a/originator.c +++ b/originator.c @@ -1074,7 +1074,8 @@ int batadv_orig_hardif_seq_print_text(struct seq_file *seq, void *offset) bat_priv->bat_algo_ops->bat_orig_print(bat_priv, seq, hard_iface); out: - batadv_hardif_free_ref(hard_iface); + if (hard_iface) + batadv_hardif_free_ref(hard_iface); return 0; } -- 2.0.0.rc0

8 years, 10 months

[B.A.T.M.A.N.] [PATCH] batman-adv: fix NULL pointer dereferences

by Marek Lindner

Reported-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- multicast.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/multicast.c b/multicast.c index 8c7ca81..96b66fd 100644 --- a/multicast.c +++ b/multicast.c @@ -415,7 +415,7 @@ batadv_mcast_forw_ipv4_node_get(struct batadv_priv *bat_priv) hlist_for_each_entry_rcu(tmp_orig_node, &bat_priv->mcast.want_all_ipv4_list, mcast_want_all_ipv4_node) { - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!atomic_inc_not_zero(&tmp_orig_node->refcount)) continue; orig_node = tmp_orig_node; @@ -442,7 +442,7 @@ batadv_mcast_forw_ipv6_node_get(struct batadv_priv *bat_priv) hlist_for_each_entry_rcu(tmp_orig_node, &bat_priv->mcast.want_all_ipv6_list, mcast_want_all_ipv6_node) { - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!atomic_inc_not_zero(&tmp_orig_node->refcount)) continue; orig_node = tmp_orig_node; @@ -493,7 +493,7 @@ batadv_mcast_forw_unsnoop_node_get(struct batadv_priv *bat_priv) hlist_for_each_entry_rcu(tmp_orig_node, &bat_priv->mcast.want_all_unsnoopables_list, mcast_want_all_unsnoopables_node) { - if (!atomic_inc_not_zero(&orig_node->refcount)) + if (!atomic_inc_not_zero(&tmp_orig_node->refcount)) continue; orig_node = tmp_orig_node; -- 2.0.0.rc0

8 years, 10 months

[B.A.T.M.A.N.] Batman-adv high TQ and Low throughput

by cmsv

Recently i have experienced something quite usual to my experience and that was not happening previously in the same scenario where it is happening now. Here is the example: 2 nodes at with adhoc at 2.4ghz at a distance of 415 meters one uses an omni 15 dbi antenna at 18dbi and another 24 dbi grid at 16 dbi. This link was previously providing up to 21 mbit being 17 mbit a the lowest. Batman-adv TQ value was always around 230 being many times above 250. However this has recently changed the same link with 230~250 TQ and the same txpower is now outputting 1.93 Mbits/sec I have used iperf for bandwidth tests. Batman-adv version is 2013.4. Although i have considered several types of scenarios that can be causing this issue i have also tested against some which leaves me puzzled in regards to the presented TQ quality and dBm values as the nodes dBm are sometimes bad (ie: -80 ~ -90) One of the main questions is: shouldn't batman-adv TQ reflect or be influenced by dBm values ? How come with -90 dBm i get batman-adv to show me 230 TQ ? Also any feedback based on your experience regarding this type of scenario is welcome. This situation happened overnight without any access point new configurations or physical setup changes. -- Site: http://wirelesspt.net Mesh: http://tinyurl.com/wirelesspt Admin: http://wirelesspt.net/wiki/Cmsv Twitter: http://twitter.com/wirelesspt Youtube: https://youtube.com/wirelesspt Facebook: https://www.facebook.com/wirelesspt Suporte técnico via sms: 91 19 11 798 Donativos/Paypal: http://tinyurl.com/doar-verba Chave publica PGP/SSH: http://wirelesspt.net/arquivos/pk Email ao abrigo de: https://creativecommons.org/licenses/by-nc-sa/3.0/pt/

8 years, 10 months

[B.A.T.M.A.N.] MTU issue

by Saurabh Chakrabarti

Following the Troubleshooting guide, I have changed the MTU for bat0 interface to 1524. I'm getting this message in my syslog: Jan 1 00:00:53 localhost kernel: [ 26.899762] batman_adv: bat0: The MTU of interface wlan0 is too small (1524) to handle the transport of batman-adv packets. Packets going over this interface will be fragmented on layer2 which could impact the performance. Setting the MTU to 1560 would solve the problem. I'm not seeing any apparent performance issues, but do I really need to make the MTU 1560? -saurabh

8 years, 11 months

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N April 2014