Hi,
you've created the batman_adv.h for the netlink interface of batman-adv and you've used the GPL-2-only license header. It is a header which is installed for userspace programs and will maybe be used for things which have a different license then the GPL-2. So it would maybe better for these use cases to have clear statement that they can use it freely. This can for example be done with a more liberal license like the ISC [1] (like in nl80211.h [2]).
What do you think about a license change? If you agree then I would like to propose a patch which requires a reply by you with an "Acked-by: ...".
Kind regards, Sven
[1] https://en.wikipedia.org/wiki/ISC_license [2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include...
The batman_adv.h netlink header is used by userspace programs to use the genl interface of batman-adv. These programs may not use the GPL-2 license. The header should therefore state clearly that it can be used freely and the license of the program which uses this header is not affected.
Signed-off-by: Sven Eckelmann sven@narfation.org Cc: Matthias Schiffer mschiffer@universe-factory.net --- include/uapi/linux/batman_adv.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index acb72f8..0fbf6fd 100644 --- a/include/uapi/linux/batman_adv.h +++ b/include/uapi/linux/batman_adv.h @@ -2,17 +2,17 @@ * * Matthias Schiffer * - * This program is free software; you can redistribute it and/or - * modify it under the terms of version 2 of the GNU General Public - * License as published by the Free Software Foundation. + * Permission to use, copy, modify, and/or distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyright notice and this permission notice appear in all copies. * - * This program is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, see http://www.gnu.org/licenses/. + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */
#ifndef _UAPI_LINUX_BATMAN_ADV_H_
On 07/04/2016 10:36 AM, Sven Eckelmann wrote:
The batman_adv.h netlink header is used by userspace programs to use the genl interface of batman-adv. These programs may not use the GPL-2 license. The header should therefore state clearly that it can be used freely and the license of the program which uses this header is not affected.
Signed-off-by: Sven Eckelmann sven@narfation.org Cc: Matthias Schiffer mschiffer@universe-factory.net
Acked-by: Matthias Schiffer mschiffer@universe-factory.net
include/uapi/linux/batman_adv.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/include/uapi/linux/batman_adv.h b/include/uapi/linux/batman_adv.h index acb72f8..0fbf6fd 100644 --- a/include/uapi/linux/batman_adv.h +++ b/include/uapi/linux/batman_adv.h @@ -2,17 +2,17 @@
- Matthias Schiffer
- This program is free software; you can redistribute it and/or
- modify it under the terms of version 2 of the GNU General Public
- License as published by the Free Software Foundation.
- Permission to use, copy, modify, and/or distribute this software for any
- purpose with or without fee is hereby granted, provided that the above
- copyright notice and this permission notice appear in all copies.
- This program is distributed in the hope that it will be useful, but
- WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, see http://www.gnu.org/licenses/.
- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
*/
- OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
#ifndef _UAPI_LINUX_BATMAN_ADV_H_
b.a.t.m.a.n@lists.open-mesh.org
-
Matthias Schiffer -
Sven Eckelmann