Use more preferable function name which implies using a pseudo-random number generator.
Signed-off-by: Akinobu Mita akinobu.mita@gmail.com Acked-by: Antonio Quartulli ordex@autistici.org Cc: Marek Lindner lindner_marek@yahoo.de Cc: Simon Wunderlich siwu@hrz.tu-chemnitz.de Cc: Antonio Quartulli ordex@autistici.org Cc: b.a.t.m.a.n@lists.open-mesh.org Cc: "David S. Miller" davem@davemloft.net Cc: netdev@vger.kernel.org ---
No change from v1
net/batman-adv/bat_iv_ogm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index 7d02ebd..bc434c4 100644 --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -123,7 +123,7 @@ batadv_iv_ogm_emit_send_time(const struct batadv_priv *bat_priv) unsigned int msecs;
msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER; - msecs += random32() % (2 * BATADV_JITTER); + msecs += prandom_u32() % (2 * BATADV_JITTER);
return jiffies + msecs_to_jiffies(msecs); } @@ -131,7 +131,7 @@ batadv_iv_ogm_emit_send_time(const struct batadv_priv *bat_priv) /* when do we schedule a ogm packet to be sent */ static unsigned long batadv_iv_ogm_fwd_send_time(void) { - return jiffies + msecs_to_jiffies(random32() % (BATADV_JITTER / 2)); + return jiffies + msecs_to_jiffies(prandom_u32() % (BATADV_JITTER / 2)); }
/* apply hop penalty for a normal link */
On Thu, Jan 03, 2013 at 09:19:15PM +0900, Akinobu Mita wrote:
Use more preferable function name which implies using a pseudo-random number generator.
Signed-off-by: Akinobu Mita akinobu.mita@gmail.com Acked-by: Antonio Quartulli ordex@autistici.org Cc: Marek Lindner lindner_marek@yahoo.de Cc: Simon Wunderlich siwu@hrz.tu-chemnitz.de Cc: Antonio Quartulli ordex@autistici.org Cc: b.a.t.m.a.n@lists.open-mesh.org Cc: "David S. Miller" davem@davemloft.net Cc: netdev@vger.kernel.org
Hello Akinobu,
as you can see in 201301021952.49979.lindner_marek@yahoo.de, Marek Lindner already applied this change onto our tree. You didn't need to resend this patch to netdev, it will be sent by us through a future pull request.
Thanks a lot. Cheers,
2013/1/4 Antonio Quartulli ordex@autistici.org:
On Thu, Jan 03, 2013 at 09:19:15PM +0900, Akinobu Mita wrote:
Use more preferable function name which implies using a pseudo-random number generator.
Signed-off-by: Akinobu Mita akinobu.mita@gmail.com Acked-by: Antonio Quartulli ordex@autistici.org Cc: Marek Lindner lindner_marek@yahoo.de Cc: Simon Wunderlich siwu@hrz.tu-chemnitz.de Cc: Antonio Quartulli ordex@autistici.org Cc: b.a.t.m.a.n@lists.open-mesh.org Cc: "David S. Miller" davem@davemloft.net Cc: netdev@vger.kernel.org
Hello Akinobu,
as you can see in 201301021952.49979.lindner_marek@yahoo.de, Marek Lindner already applied this change onto our tree. You didn't need to resend this patch to netdev, it will be sent by us through a future pull request.
Yes. I read Marek's email. But I included it in v2 again in order not to break the build. Because it doesn't show up the latest linux-next yet and the last patch 26/26 removes random32() and srandom32().
But I should have mentioned it and trimmed the Cc list. Sorry for the confusion.
On Fri, Jan 04, 2013 at 10:50:41PM +0900, Akinobu Mita wrote:
2013/1/4 Antonio Quartulli ordex@autistici.org:
On Thu, Jan 03, 2013 at 09:19:15PM +0900, Akinobu Mita wrote:
Use more preferable function name which implies using a pseudo-random number generator.
Signed-off-by: Akinobu Mita akinobu.mita@gmail.com Acked-by: Antonio Quartulli ordex@autistici.org Cc: Marek Lindner lindner_marek@yahoo.de Cc: Simon Wunderlich siwu@hrz.tu-chemnitz.de Cc: Antonio Quartulli ordex@autistici.org Cc: b.a.t.m.a.n@lists.open-mesh.org Cc: "David S. Miller" davem@davemloft.net Cc: netdev@vger.kernel.org
Hello Akinobu,
as you can see in 201301021952.49979.lindner_marek@yahoo.de, Marek Lindner already applied this change onto our tree. You didn't need to resend this patch to netdev, it will be sent by us through a future pull request.
Yes. I read Marek's email. But I included it in v2 again in order not to break the build. Because it doesn't show up the latest linux-next yet and the last patch 26/26 removes random32() and srandom32().
But I should have mentioned it and trimmed the Cc list. Sorry for the confusion.
Ok..everything is fine as soon David won't apply this patch. Cheers,
b.a.t.m.a.n@lists.open-mesh.org