The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to the an config entry.
Reported-by: Sergei Shtylyov sergei.shtylyov@cogentembedded.com Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/Kconfig | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index de8034d80623..41bb67d70c83 100644 --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -24,7 +24,6 @@ config BATMAN_ADV depends on NET select CRC16 select LIBCRC32C - default n help B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is a routing protocol for multi-hop ad-hoc mesh networks. The @@ -60,7 +59,6 @@ config BATMAN_ADV_BLA config BATMAN_ADV_DAT bool "Distributed ARP Table" depends on BATMAN_ADV && INET - default n help This option enables DAT (Distributed ARP Table), a DHT based mechanism that increases ARP reliability on sparse wireless @@ -70,7 +68,6 @@ config BATMAN_ADV_DAT config BATMAN_ADV_NC bool "Network Coding" depends on BATMAN_ADV - default n help This option enables network coding, a mechanism that aims to increase the overall network throughput by fusing multiple @@ -84,7 +81,6 @@ config BATMAN_ADV_NC config BATMAN_ADV_MCAST bool "Multicast optimisation" depends on BATMAN_ADV && INET && !(BRIDGE=m && BATMAN_ADV=y) - default n help This option enables the multicast optimisation which aims to reduce the air overhead while improving the reliability of @@ -94,7 +90,6 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS - default n help Enable this to export routing related debug tables via debugfs. The information for each soft-interface and used hard-interface can be
The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental.
Reported-by: Joe Perches joe@perches.com Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index 41bb67d70c83..da0b7aa98be9 100644 --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -32,7 +32,7 @@ config BATMAN_ADV tools.
config BATMAN_ADV_BATMAN_V - bool "B.A.T.M.A.N. V protocol (experimental)" + bool "B.A.T.M.A.N. V protocol" depends on BATMAN_ADV && !(CFG80211=m && BATMAN_ADV=y) default y help
On 5/25/2018 10:48 PM, Sven Eckelmann wrote:
The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to the an config entry.
^^^^^^ One article would be enough. And it's "a", not "an" in this case. :-)
Reported-by: Sergei Shtylyov sergei.shtylyov@cogentembedded.com Signed-off-by: Sven Eckelmann sven@narfation.org
[...]
MBR, Sergei
b.a.t.m.a.n@lists.open-mesh.org