Hi there,
Not sure how you guys want patches submitted, so point me in the right direction if this is not it. Here's a simple patch that enables compilation on linux-2.6.21 (and possibly earlier, though I've tested 2.6.16 and it doesn't work).
Cheers,
-- Scott Raynel WAND Network Research Group Department of Computer Science University of Waikato New Zealand
Hey Scott,
thank you for the patch, it looks good to me so i applied it. Having a compat.h is a good idea, maybe we should use it even more to get rid of some ugly #ifdef's. :) I've tested your patch against various kernels, it seems to work until 2.6.20, but breaks for 2.6.19.
We welcome any kind of patches, so don't hesitate to submit. We can integrate them directly (like your patch) or offer them on our homepage (like the quagga patches [1]).
Thanks again, Simon
[1] http://downloads.open-mesh.net/batman/patches/quagga/
On Thu, Jul 17, 2008 at 01:34:53PM +1200, Scott Raynel wrote:
Hi there,
Not sure how you guys want patches submitted, so point me in the right direction if this is not it. Here's a simple patch that enables compilation on linux-2.6.21 (and possibly earlier, though I've tested 2.6.16 and it doesn't work).
Cheers,
-- Scott Raynel WAND Network Research Group Department of Computer Science University of Waikato New Zealand
B.A.T.M.A.N mailing list B.A.T.M.A.N@open-mesh.net https://list.open-mesh.net/mm/listinfo/b.a.t.m.a.n
Hi Simon,
On 17/07/2008, at 8:00 PM, Simon Wunderlich wrote:
Hey Scott,
thank you for the patch, it looks good to me so i applied it. Having a compat.h is a good idea, maybe we should use it even more to get rid of some ugly #ifdef's. :) I've tested your patch against various kernels, it seems to work until 2.6.20, but breaks for 2.6.19.
Great, thanks. The idea of a compat.h for those macros is blatantly stolen from madwifi, which I'm a casual contributor to :) If I get some more spare time I'll look at fixes for earlier kernels, but I needed to target 2.6.21 with a project I'm working on, hence the patch :)
We welcome any kind of patches, so don't hesitate to submit. We can integrate them directly (like your patch) or offer them on our homepage (like the quagga patches [1]).
I'll keep that in mind - hopefully as we start to play with the module some more I'll be able contribute further.
Cheers,
-- Scott Raynel WAND Network Research Group Department of Computer Science University of Waikato New Zealand
On Thursday, 17. July 2008 16:00:54 Simon Wunderlich wrote:
thank you for the patch, it looks good to me so i applied it. Having a compat.h is a good idea, maybe we should use it even more to get rid of some ugly #ifdef's. :)
Yes, I agree - I like that idea.
We welcome any kind of patches, so don't hesitate to submit. We can integrate them directly (like your patch) or offer them on our homepage (like the quagga patches [1]).
Correct - just send us what you have and we can directly integrate it. :-)
Greetings, Marek
b.a.t.m.a.n@lists.open-mesh.org
-
Marek Lindner -
Scott Raynel -
Simon Wunderlich