Re: [B.A.T.M.A.N.] New Defects reported by Coverity Scan for batctl - B.A.T.M.A.N - lists.open-mesh.org

20 Mar 2018

On Mon, Mar 19, 2018 at 01:17:37AM +0000, scan-admin(a)coverity.com wrote:
[...]
...

________________________________________________________________________________________________________
 *** CID 174547:  Incorrect expression  (COPY_PASTE_ERROR)
 /netlink.c: 255 in info_callback()
 249     		else
 250     			mcast_flags = -EOPNOTSUPP;
 251     
 252     		if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV])
 253     			mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]);
 254     		else
 >>     CID 174547:  Incorrect expression 
(COPY_PASTE_ERROR)
>>     "mcast_flags" in "mcast_flags = -95L" looks like a
copy-paste error. 
 255     			mcast_flags = -EOPNOTSUPP; [...]

Now this is officially the second time a code/patch reviewing
algorithm creeps me out :D.

"Looks like", yeah... and even worse, the AI is actually right...
I will send a fix :).

Cheers