Hi all,
i thought it was a good idea to move the functions "start_mesh" and "stop_mesh" from /etc/init.d/batman-adv script to a new file in openwrt style "/lib/batman-adv/config.sh". With this improvment it possible to recycle this two function to operate with an hotplug script so when network restart, all batman interface will be reconfigured automatically and I just work to do this. In this mail you can find batman-adv initscript updated to work in this way and the batman-adv library file that must be located in /lib/batman-adv/. Any comment are apprecciated
-- Filippo Sallemi
Hi,
In this mail you can find batman-adv initscript updated to work in this way and the batman-adv library file that must be located in /lib/batman-adv/.
I liked the idea of having hotplug hooks to restart the batman-adv configuration automatically. Generally, the scripts look good to me. You also changed its "coding style", e.g. $var -> ${var}. This does not look very OpenWRT-ish, therefore I would prefer keeping the current style. Any objections ?
Regards, Marek
No. no prblem from me
2011/8/16 Marek Lindner lindner_marek@yahoo.de:
Hi,
In this mail you can find batman-adv initscript updated to work in this way and the batman-adv library file that must be located in /lib/batman-adv/.
I liked the idea of having hotplug hooks to restart the batman-adv configuration automatically. Generally, the scripts look good to me. You also changed its "coding style", e.g. $var -> ${var}. This does not look very OpenWRT-ish, therefore I would prefer keeping the current style. Any objections ?
Regards, Marek
Ok. I'm just working on it
2011/8/22 Marek Lindner lindner_marek@yahoo.de:
On Wednesday, August 17, 2011 06:54:20 Filippo Sallemi wrote:
No. no prblem from me
Ok, I just comitted the new package. Let me know when you have the hotplug stuff ready to be included as well.
Regards, Marek
Hi all, I've writed a hotplug.d script that readd interfaces that are present in every bat definition of batman-adv uci file when network restart or an interface come up. This script must be placed in /etc/hotplug.d/net/
P.S. for Marek you don't need to split /etc/init.d/batman-adv function in a separate file such the previous emails.
Rgds.
Filippo
2011/8/24 Filippo Sallemi tonyputi@gmail.com:
Ok. I'm just working on it
2011/8/22 Marek Lindner lindner_marek@yahoo.de:
On Wednesday, August 17, 2011 06:54:20 Filippo Sallemi wrote:
No. no prblem from me
Ok, I just comitted the new package. Let me know when you have the hotplug stuff ready to be included as well.
Regards, Marek
-- Filippo Sallemi
Filippo,
I've writed a hotplug.d script that readd interfaces that are present in every bat definition of batman-adv uci file when network restart or an interface come up. This script must be placed in /etc/hotplug.d/net/
P.S. for Marek you don't need to split /etc/init.d/batman-adv function in a separate file such the previous emails.
I am little bit late with your script but finally got around looking at it. Why don't we use the functions from /lib/batman-adv/config.sh as we previously discussed ? Any unexpected side effects ?
Regards, Marek
b.a.t.m.a.n@lists.open-mesh.org
-
Filippo Sallemi -
Marek Lindner