The batctl makefile has CFLAGS which change the behavior of the compiler. This includes important things like the C-dialect used or whether the compiler can ignore aliasing problems during the optimization step.
The OpenWRT build environment should not overwrite these settings without a good reason. Most of these reasons can probably directly be fixed upstream.
Signed-off-by: Sven Eckelmann sven@narfation.org --- batman-adv-devel/Makefile | 3 --- 1 file changed, 3 deletions(-)
diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index cad95c6..fb2c24a 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -65,9 +65,6 @@ MAKE_BATMAN_ADV_ARGS += \ REVISION="$(PKG_BATMAN_SHORTREV)" all
MAKE_BATCTL_ARGS += \ - CFLAGS="$(TARGET_CFLAGS)" \ - CCFLAGS="$(TARGET_CFLAGS)" \ - OFLAGS="$(TARGET_CFLAGS)" \ REVISION="$(PKG_BATCTL_SHORTREV)" \ CC="$(TARGET_CC)" \ NODEBUG=1 \
The NODEBUG, UNAME and STRIP parameter aren't used in batctl's Makefile. Removing them should be safe.
Signed-off-by: Sven Eckelmann sven@narfation.org --- batman-adv-devel/Makefile | 3 --- 1 file changed, 3 deletions(-)
diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile index fb2c24a..4689181 100644 --- a/batman-adv-devel/Makefile +++ b/batman-adv-devel/Makefile @@ -67,10 +67,7 @@ MAKE_BATMAN_ADV_ARGS += \ MAKE_BATCTL_ARGS += \ REVISION="$(PKG_BATCTL_SHORTREV)" \ CC="$(TARGET_CC)" \ - NODEBUG=1 \ - UNAME="Linux" \ DESTDIR="$(PKG_INSTALL_DIR)" \ - STRIP="/bin/true" \ batctl install
TARGET_CFLAGS += -ffunction-sections -fdata-sections -flto
On Wednesday, May 08, 2013 15:21:26 Sven Eckelmann wrote:
The NODEBUG, UNAME and STRIP parameter aren't used in batctl's Makefile. Removing them should be safe.
Signed-off-by: Sven Eckelmann sven@narfation.org
batman-adv-devel/Makefile | 3 --- 1 file changed, 3 deletions(-)
Applied in revision ffa6898.
Thanks, Marek
On Wednesday, May 08, 2013 15:21:25 Sven Eckelmann wrote:
The batctl makefile has CFLAGS which change the behavior of the compiler. This includes important things like the C-dialect used or whether the compiler can ignore aliasing problems during the optimization step.
The OpenWRT build environment should not overwrite these settings without a good reason. Most of these reasons can probably directly be fixed upstream.
Signed-off-by: Sven Eckelmann sven@narfation.org
batman-adv-devel/Makefile | 3 --- 1 file changed, 3 deletions(-)
Applied in revision 110ca73.
Thanks, Marek
b.a.t.m.a.n@lists.open-mesh.org
-
Marek Lindner -
Sven Eckelmann