The string representation for a mac address produced by %pM is 16 characters long. Left-aligning the output in a 15 character wide field with %-15pM is therefore misleading and unnecessary.
Signed-off-by: Sven Eckelmann sven@narfation.org --- This change should be placed near https://git.open-mesh.org/batman-adv.git/commit/ea9e7718812648894c2aeca3cd47...
net/batman-adv/bat_iv_ogm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index 8769fa1b..83ba5483 100644 --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -1279,7 +1279,7 @@ static bool batadv_iv_ogm_calc_tq(struct batadv_orig_node *orig_node, batadv_ogm_packet->tq = combined_tq;
batadv_dbg(BATADV_DBG_BATMAN, bat_priv, - "bidirectional: orig = %-15pM neigh = %-15pM => own_bcast = %2i, real recv = %2i, local tq: %3i, asym_penalty: %3i, iface_penalty: %3i, total tq: %3i, if_incoming = %s, if_outgoing = %s\n", + "bidirectional: orig = %pM neigh = %pM => own_bcast = %2i, real recv = %2i, local tq: %3i, asym_penalty: %3i, iface_penalty: %3i, total tq: %3i, if_incoming = %s, if_outgoing = %s\n", orig_node->orig, orig_neigh_node->orig, total_count, neigh_rq_count, tq_own, tq_asym_penalty, tq_iface_penalty, batadv_ogm_packet->tq, if_incoming->net_dev->name,
On Sonntag, 18. Juni 2017 10:12:30 CEST Sven Eckelmann wrote:
The string representation for a mac address produced by %pM is 16 characters long. Left-aligning the output in a 15 character wide field with %-15pM is therefore misleading and unnecessary.
Signed-off-by: Sven Eckelmann sven@narfation.org
Applied as 2bfa77d941c4b20af879cf85730b103766b5a709 [1]
Kind regards, Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/2bfa77d941c4b20af879cf85730b...
b.a.t.m.a.n@lists.open-mesh.org