Hello
when trying to compile the latest batctl code from the git repository I run into a compiler error (gcc 4.8.5 and eglibc-2.18) .
As far as I could figure out the problem is caused by the define of __unused in main.h. In my case I use the libnl-3.2.25 to compile the code. The libnl header files include the netdb.h header file which uses __unused as an element of a struct. The define in the main.h of the batctl code leads to a compiler error. Renaming the define in main.h to something like __unused_ and corresponding changes in the batctl code using __unused solves the compile time issue. But due to my lack of knowledge I don't know if this breaks the code.... On my devices batctl seems to work properly after changing this, but before sending a patch, I would like to ask you guys first ;-)
Best regards, Andreas
.................................................................. PHOENIX CONTACT ELECTRONICS GmbH
Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont USt-Id-Nr.: DE811742156 Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528 Geschäftsführer / Executive Board: Ulrich Leidecker, Christoph Leifer __________________________________________________________________ Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren, jegliche anderweitige Verwendung sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. ---------------------------------------------------------------------------------------------------- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. ___________________________________________________________________
On Donnerstag, 15. September 2016 11:00:03 CEST Andreas Pape wrote:
Hello
when trying to compile the latest batctl code from the git repository I run into a compiler error (gcc 4.8.5 and eglibc-2.18) .
Please test https://patchwork.open-mesh.org/patch/16673/ (and reply with a Tested-by: Andreas Pape APape@phoenixcontact.com) when it works.
Kind regards, Sven
Hi Sven,
this patch works for me. Sorry for not finding your patch in patchwork myself. Stupid question: how and where do I reply with Tested-by....?
Best regards, Andreas
Sven Eckelmann sven@narfation.org schrieb am 15.09.2016 11:19:33:
Von: Sven Eckelmann sven@narfation.org An: b.a.t.m.a.n@lists.open-mesh.org Kopie: Andreas Pape APape@phoenixcontact.com Datum: 15.09.2016 11:19 Betreff: Re: [B.A.T.M.A.N.] batctl: problem with #define __unused in
main.h
On Donnerstag, 15. September 2016 11:00:03 CEST Andreas Pape wrote:
Hello
when trying to compile the latest batctl code from the git repository
I
run into a compiler error (gcc 4.8.5 and eglibc-2.18) .
Please test https://patchwork.open-mesh.org/patch/16673/ (and reply with
a
Tested-by: Andreas Pape APape@phoenixcontact.com) when it works.
Kind regards, Sven[Anhang "signature.asc" gelöscht von Andreas Pape/Pyr/DE/ Phoenix Contact]
.................................................................. PHOENIX CONTACT ELECTRONICS GmbH
Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont USt-Id-Nr.: DE811742156 Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528 Geschäftsführer / Executive Board: Ulrich Leidecker, Christoph Leifer __________________________________________________________________ Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren, jegliche anderweitige Verwendung sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. ---------------------------------------------------------------------------------------------------- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. ___________________________________________________________________
On Donnerstag, 15. September 2016 12:19:20 CEST Andreas Pape wrote:
Hi Sven,
this patch works for me. Sorry for not finding your patch in patchwork myself. Stupid question: how and where do I reply with Tested-by....?
Its not a stupid question. You can download the mbox file containing the mail at https://patchwork.open-mesh.org/patch/16673/mbox/. Just open it with your mailer and reply to this mail.
Or you can (when your mailer allows it) use the In-Reply-To header and point it at 20160904182331.18118-1-sven@narfation.org. The mail can then be written like any other mail.
And when your normal mailer doesn't want to do it - (mis)use git-send-email:
cat > mail.mbox << EOF From: Andreas Pape apape@phoenixcontact.com Date: Thu, 15 Sep 2016 13:40:09 +0200 Subject: Re: [PATCH] batctl: Work around uclibc collision for __unused
uclibc on 64 bit systems uses struct members called __unused. These conflict with the definition of __unused in batctl. Such a conflict results in a build error because the struct member will be replaced with the __attribute__((unused)).
This can be avoided by renaming it to the Linux kernel name "__maybe_unused".
Signed-off-by: Sven Eckelmann sven@narfation.org
Tested-by: Andreas Pape apape@phoenixcontact.com EOF git send-email --in-reply-to=20160904182331.18118-1-sven@narfation.org --to=b.a.t.m.a.n@lists.open-mesh.org mail.mbox
I hope this helps :)
Kind regards, Sven
b.a.t.m.a.n@lists.open-mesh.org
-
Andreas Pape -
Sven Eckelmann