[B.A.T.M.A.N.] Antwort: Re: [PATCH 1/7] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled
Hello Sven,
Sven Eckelmann sven@narfation.org schrieb am 25.02.2016 11:30:01:
I will answer to the first patch only because this patchset doesn't have
a
cover letter. But it is about the whole patchset.
First thing: Good that you could convince the IT department that you
have to
use git-send-email as alternative mailer.
I have not checked the actual content of the patchset ("This patch
makes" in
the commit messages looks odd) but just started the build_test [1] on
your
patchset. It looks like your patchset doesn't build in some
configurations.
See the attached mail for more details.
I wasn't aware that there is something like the build_test to be used before sending patches.... But I'm willing to learn.
Is there a documentation available how I can use this myself for testing before making another attempt to send the patches (including a cover letter)?
In my buildenvironment using an older kernel I have no issues. But of course I did not test every possible configuration....
And the test run without your patches looked good [2].
Kind regards, Sven
[1] https://git.open-mesh.org/build_test.git [2] https://lists.open-mesh.org/pipermail/linux-merge/2016-February/ 002983.html [Anhang "build-test_andreas-pape_bla-fixes.mbox" gelöscht von Andreas Pape/Phoenix Contact] [Anhang "signature.asc" gelöscht von Andreas Pape/Phoenix Contact]
.................................................................. PHOENIX CONTACT ELECTRONICS GmbH
Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont USt-Id-Nr.: DE811742156 Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528 Geschäftsführer / Executive Board: Roland Bent, Dr. Martin Heubeck ___________________________________________________________________ Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren, jegliche anderweitige Verwendung sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. ---------------------------------------------------------------------------------------------------- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. ___________________________________________________________________
On Thursday 25 February 2016 14:06:39 Andreas Pape wrote:
I wasn't aware that there is something like the build_test to be used before sending patches.... But I'm willing to learn.
No, build_test is not something which has be used. It is actually quite hacky and only used in the daily tests (and by brave people still wanting to use it).
But you should [1] compile your stuff with sparse. Install it and run the compile with:
make C=2 CHECK="sparse -Wsparse-all -Wno-ptr-subtraction-blows -D__CHECK_ENDIAN__"
You can ignore the "shadows an earlier one" in the external headers and the one about __ret.
And you should definitely use the checkpatch.pl from linux-next:
~/linux-next/scripts/checkpatch.pl --strict 000*.patch
Is there a documentation available how I can use this myself for testing before making another attempt to send the patches (including a cover letter)?
If you really want to test it with build_test then you have to clone it on an amd64 system, install iwyu (3.5+), python and the standard build tools. This example expects that you have a working mail server on your system which at least can send mails to a local account (YOUR_MAIL_ACCOUNT). The patches in YOUR_BATMAN_ADV_TREE should be in the master branch to avoid too many changes checkstuff.sh.
git clone git://git.open-mesh.org/build_test.git cd build_test git clone git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git linux-next git --git-dir=linux-next/.git/ remote add net-next git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git LINUX_REPOSITORY=`pwd`/linux-next ./generate_linux_headers.sh sudo mkdir linux-build sudo mount linux-build.img -o loop linux-build # edit checkstuff.sh and remove: testbranch "next" TO=YOUR_MAIL_ACCOUNT REMOTE=YOUR_BATMAN_ADV_TREE ./checkstuff.sh # fix all the stuff regarding sparse, cppcheck, smatch and try again: TO=YOUR_MAIL_ACCOUNT REMOTE=YOUR_BATMAN_ADV_TREE ./checkstuff.sh
Cover letter can be generated in git sendmail by running:
git send-email --compose 0001-.... 0002-... ....
It is not really required. I just wanted to tell you that the result is not really about this single patch. But please add all patches to the call of `git send-email` to automatically create a single thread.
Kind regards, Sven
[1] https://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patc...
b.a.t.m.a.n@lists.open-mesh.org
-
Andreas Pape -
Sven Eckelmann