batadv_mcast_forw_ip_node_get() returns a pointer, so returning NULL in error cases is always more appropriate than 0.
Introduced by: c8fedbea81eac41a4971bb43353fd52a903d7c4c ("batman-adv: Send multicast packets to nodes with a WANT_ALL flag")
Reported-by: Antonio Quartulli antonio@meshcoding.com Signed-off-by: Linus Lüssing linus.luessing@web.de --- * added Reported-by
multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/multicast.c b/multicast.c index b2abe00..00bb30e 100644 --- a/multicast.c +++ b/multicast.c @@ -498,7 +498,7 @@ batadv_mcast_forw_ip_node_get(struct batadv_priv *bat_priv, return batadv_mcast_forw_ipv6_node_get(bat_priv); default: /* we shouldn't be here... */ - return 0; + return NULL; } }
On Sunday 16 February 2014 10:27:58 Linus Lüssing wrote:
batadv_mcast_forw_ip_node_get() returns a pointer, so returning NULL in error cases is always more appropriate than 0.
Introduced by: c8fedbea81eac41a4971bb43353fd52a903d7c4c ("batman-adv: Send multicast packets to nodes with a WANT_ALL flag")
Reported-by: Antonio Quartulli antonio@meshcoding.com Signed-off-by: Linus Lüssing linus.luessing@web.de
- added Reported-by
multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision 0dd5d2c.
Thanks, Marek
b.a.t.m.a.n@lists.open-mesh.org