On Tuesday, 19 October 2021 21:06:54 CEST Jakub Kicinski wrote:

On Tue, 19 Oct 2021 09:39:27 -0700 Jakub Kicinski wrote:

...

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount of VLANs...") introduced a rbtree for faster Ethernet address look up. To maintain netdev->dev_addr in this tree we need to make all the writes to it got through appropriate helpers.

Convert batman from ether_addr_copy() to eth_hw_addr_set():

@@ expression dev, np; @@

• ether_addr_copy(dev->dev_addr, np)

• eth_hw_addr_set(dev, np)

Signed-off-by: Jakub Kicinski kuba@kernel.org

Extending CC list.

Acked-by: Sven Eckelmann sven@narfation.org

...

diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 0604b0279573..7ee09337fc40 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -134,7 +134,7 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p) return -EADDRNOTAVAIL;

ether_addr_copy(old_addr, dev->dev_addr);

• ether_addr_copy(dev->dev_addr, addr->sa_data);

• eth_hw_addr_set(dev, addr->sa_data);

  /* only modify transtable if it has been initialized before */ if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE)