To simplify TranslationTable debugging it is better to print the packet rerouting message on the DBG_TT log level. In this way a developer interested in packets rerouting doesn't need to filter it out of the whole ROUTES log.
Moreover, since this message will appear for each rerouted message, it is now "ratelimited".
Signed-off-by: Antonio Quartulli ordex@autistici.org --- routing.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/routing.c b/routing.c index e7a4e25..f9751a0 100644 --- a/routing.c +++ b/routing.c @@ -972,10 +972,11 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv, batadv_orig_node_free_ref(orig_node); }
- batadv_dbg(BATADV_DBG_ROUTES, bat_priv, - "TTVN mismatch (old_ttvn %u new_ttvn %u)! Rerouting unicast packet (for %pM) to %pM\n", - unicast_packet->ttvn, curr_ttvn, ethhdr->h_dest, - unicast_packet->dest); + if (net_ratelimit()) + batadv_dbg(BATADV_DBG_TT, bat_priv, + "TTVN mismatch (old_ttvn %u new_ttvn %u)! Rerouting unicast packet (for %pM) to %pM\n", + unicast_packet->ttvn, curr_ttvn, + ethhdr->h_dest, unicast_packet->dest);
unicast_packet->ttvn = curr_ttvn; }
On Fri, Aug 24, 2012 at 06:18:42PM +0200, Antonio Quartulli wrote:
To simplify TranslationTable debugging it is better to print the packet rerouting message on the DBG_TT log level. In this way a developer interested in packets rerouting doesn't need to filter it out of the whole ROUTES log.
Moreover, since this message will appear for each rerouted message, it is now "ratelimited".
Signed-off-by: Antonio Quartulli ordex@autistici.org
Sorry, drop this patch, I should have used net_ratelimited_function, as I told to Martin.
Will send v2.
Cheers,
b.a.t.m.a.n@lists.open-mesh.org