From: Antonio Quartulli antonio@open-mesh.com
The data argument in each hash function should carry the "const" qualifier as it is never modified.
Signed-off-by: Antonio Quartulli antonio@open-mesh.com --- bridge_loop_avoidance.c | 2 +- hash.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index 724adf0..5e834c1 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c @@ -57,7 +57,7 @@ static inline uint32_t batadv_choose_claim(const void *data, uint32_t size) static inline uint32_t batadv_choose_backbone_gw(const void *data, uint32_t size) { - struct batadv_claim *claim = (struct batadv_claim *)data; + const struct batadv_claim *claim = (struct batadv_claim *)data; uint32_t hash = 0;
hash = batadv_hash_bytes(hash, &claim->addr, sizeof(claim->addr)); diff --git a/hash.h b/hash.h index e053339..ea02148 100644 --- a/hash.h +++ b/hash.h @@ -89,7 +89,7 @@ static inline void batadv_hash_delete(struct batadv_hashtable *hash, * * Returns the new hash value. */ -static inline uint32_t batadv_hash_bytes(uint32_t hash, void *data, +static inline uint32_t batadv_hash_bytes(uint32_t hash, const void *data, uint32_t size) { const unsigned char *key = data;
On Friday, December 07, 2012 21:35:36 Antonio Quartulli wrote:
From: Antonio Quartulli antonio@open-mesh.com
The data argument in each hash function should carry the "const" qualifier as it is never modified.
Signed-off-by: Antonio Quartulli antonio@open-mesh.com
bridge_loop_avoidance.c | 2 +- hash.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Applied in revision 6f9250b.
Thanks, Marek
b.a.t.m.a.n@lists.open-mesh.org