Hello Linus,
I gave it a try - but there seems something off. What I did is: * apply your patches on 3b38a80 - multicast was enabled by default * start 2 VMs directly connected * ping6 -I bat0 ff02::1
I only got a reply locally, but not from the peer. When I disabled multicast, I got two replies from the local host and the peer.
As far as I have tracked the problem down, it appears that batadv_mcast_forw_mode() returns 1 correctly, but the packet is dropped later in the process - I would guess that this happens in batadv_send_generic_unicast_skb() where we try to select the gateway when the destination mac is multicast instead of looking it up in the tt table. But I leave the details to you. :)
The rest looks good, but I'll review more deeply again when it's actually working. It does compile without problems now.
Cheers, Simon
On Mon, Jun 10, 2013 at 09:11:55AM +0200, Linus Lüssing wrote:
This is the fourth revision of the basic multicast optimization patches.
It adds a missing enum keyword to the return type of a mcast_forw_mode().
Cheers, Linus