On Fri, Sep 17, 2010 at 12:27:13AM +0200, Sven Eckelmann wrote:
Andreas Langer wrote:
Sven, any idea why checkpatch (0.31)b do this ?
ERROR: space prohibited after that '-' (ctx:WxW) #10: FILE: batman-adv/routing.c:1146:
uni_diff = sizeof(struct unicast_frag_packet) - hdr_len;Because... what the heck? Usually it says that you should use consistent spaces around '-'. So better use spaces in patch 1 and 6 and don't remove the space before hdr_len as you did now.
Because it is wrong. I believe that I've fixed that one up in my development tree. Could you confirm it is correctly left alone with the version below:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-t...
My version from linux-next (today) is 0.30 and doesn't have a problem with spaces around those '-' (but with your version of the patches). The checkpatch.pl-testing also don't have the problem.
I would guess that it was a regression in checkpatch.pl. Maybe Andy Whitcroft knows more about it
-apw