Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: layer2 unicast packet fragmentation

On Tuesday, July 06, 2010 17:59:20 Andreas Langer wrote:

•   if (atomic_read(&bat_priv->frag_enabled) && batman_if->net_dev->mtu
  

< + ETH_DATA_LEN + BAT_HEADER_LEN)

•           bat_info(soft_device,
  

•           "The MTU of interface %s is too small (%zi) to handle "
  

•           "the transport of batman-adv packets. Packets going "
  

•           "over this interface will be fragmented on layer2 "
  

•           "which could impact the performance. Setting the MTU "
  

•           "to %zi would solve the problem.\n",
  

•            batman_if->dev, ETH_DATA_LEN + BAT_HEADER_LEN,
  

•            ETH_DATA_LEN + BAT_HEADER_LEN);
  

The required MTU gets printed twice here. I guess you wanted to print this: batman_if->dev, batman_if->net_dev->mtu, ETH_DATA_LEN + BAT_HEADER_LEN

•   if (!atomic_read(&bat_priv->frag_enabled) &&
  

batman_if->net_dev->mtu < + ETH_DATA_LEN + BAT_HEADER_LEN)

•           bat_info(soft_device,
  

•           "The MTU of interface %s is too small (%zi) to handle "
  

•           "the transport of batman-adv packets. If you experience"
  

•           " problems getting traffic through try increasing the "
  

•            "MTU to %zi.\n",
  

•            batman_if->dev, ETH_DATA_LEN + BAT_HEADER_LEN,
  

•            ETH_DATA_LEN + BAT_HEADER_LEN);
  

Here we have the same issue.

Regards, Marek