21 Nov
2024
21 Nov
'24
9:35 a.m.
On Thu, Nov 21, 2024 at 10:30:37AM +0100, Sven Eckelmann wrote:
On Thursday, 21 November 2024 10:23:33 CET Sven Eckelmann wrote:
On Thursday, 21 November 2024 10:13:15 CET Remi Pommarel wrote:
Looks right to me, I would even simplify that more for readability with:
[...]
-del:
list_del(&entry->list);kmem_cache_free(batadv_tt_change_cache, entry);bat_priv->tt.local_changes--;discard: kmem_cache_free(batadv_tt_change_cache, tt_change_node); goto unlock;
The "discard" is unused. But the rest looks good.
No, it doesn't. You've accidental removed "entry->change.flags = flags;". So it should look more like this:
Yes sorry did that too quickly. I'll wait for Antonio point of view on double DEL before respinning that.
Thanks,
--
Remi