On 2021/06/06 23:35, Sven Eckelmann wrote:
Please rebase your patch in case it is really needed.
Oh, I didn't know you already applied that change, for that commit is not yet visible from linux-next.git as of next-20210604.
And the explanation you give seems to be bogus. Or am I missing some error handling in batadv_hardif_enable_interface [1]?
I told syzbot to try https://syzkaller.appspot.com/text?tag=Patch&x=100b083fd00000 and the response ( https://syzkaller.appspot.com/text?tag=CrashLog&x=1456f0ffd00000 ) was
batman_adv: forw_packet->if_outgoing->soft_iface=0000000000000000 forw_packet->if_incoming->soft_iface=0000000039fa85b7
indicating that if_outgoing->soft_iface was NULL, and there was a memory allocation fault injection immediately before this result.
Since if_outgoing->soft_iface becomes non-NULL if batadv_hardif_enable_interface() succeeds, this situation indicates that batadv_hardif_enable_interface() failure caused forw_packet->if_outgoing->soft_iface to remain NULL.
Kind regards, Sven
[1] https://git.open-mesh.org/linux-merge.git/blob/refs/heads/batadv/net-next:/n...