On Tue, Nov 23, 2010 at 12:44:57AM +0100, Marek Lindner wrote:
On Monday 22 November 2010 22:45:53 Linus Lüssing wrote:
-static int seqno_event_new(char *iface_addr, char *orig, char *prev_sender, char *neigh, int seqno, int tq, int ttl) +static int seqno_event_new(char *iface_addr, char *orig, char *prev_sender, char *neigh, int64_t seqno, int tq, int ttl)
Didn't you forget to adjust the seqno size in the seqno_event and seqno_trace struct ? Simply declaring it 64bit in the function header won't do much good ...
Regards, Marek
Urgh, just noticed, that there seem to be even more places that need to be modified. E.g. all those seqno_min and seqno_max occurences or strtol probably needs to be stroll for the seqno, too. Using int64_t for any seqno(_min/max) occurence probably won't be sufficient either, as then printf()s for int64_t (even with %lld) won't be so nice, I guess.
Do you think using long long instead of ints for the seqnos is ok (without any int64_t usage), hoping that on every architecture a long long will be at least 8 Bytes large?
Cheers, Linus