On Tue, May 28, 2013 at 05:51:14PM +0200, Linus Lüssing wrote:
On Tue, May 28, 2013 at 05:55:44PM +0800, Marek Lindner wrote:
On Sunday, May 26, 2013 23:56:07 Linus Lüssing wrote:
@@ -572,6 +584,7 @@ static const struct net_device_ops batadv_netdev_ops = { .ndo_get_stats = batadv_interface_stats, .ndo_set_mac_address = batadv_interface_set_mac_addr, .ndo_change_mtu = batadv_interface_change_mtu,
.ndo_set_rx_mode = batadv_interface_set_rx_mode, .ndo_start_xmit = batadv_interface_tx, .ndo_validate_addr = eth_validate_addr, .ndo_add_slave = batadv_softif_slave_add,Do we need compat code for this API call ?
Cheers, Marek
Yes it does, actually. A PATCHv3 will follow soonish. Thanks for the hint!
Hm, I changed my mind, it actually shouldn't need any compat code. At least compiling worked fine for me for 2.6.29 to 3.9 kernels.
There was a .ndo_set_multicast_list once with all these calls being reassigned to .ndo_set_rx_mode and .ndo_set_multicast_list being removed since 3.2 ("net: remove use of ndo_set_multicast_list in drivers":afc4b13df143122f99a0eb10bfefb216c2806de0). However .ndo_set_rx_mode has always been threre for kernels >= 2.6.29, <= 3.9.
Cheers, Linus