On Monday 27 June 2016 00:55:21 Sven Eckelmann wrote:
This breaks for example the reference counting in batadv_interface_tx when an DHCP packet (BATADV_DHCP_TO_SERVER) is detected in a multicast (not broadcast) packet which is later detected by the multicast code as BATADV_FORW_SINGLE. The multicast code then assumes that it will send it and acquires the originator to the destination. But in reality, the DHCP forwarding code takes precedence and as result the reference counter is not decreased anymore.
Ok, just saw that this cannot happen because do_bcast would not have been set to true in this situation. And this would automatically disable the multicast detection parts. I will therefore resubmit for master instead of maint.
Kind regards, Sven