Hey Antonio,
thx for your quick reply!
Am 09.06.2014 23:05, schrieb Antonio Quartulli:
I'd suggest you to check this patch with checkpatch.pl --strict. Here I get many errors due to non-printable chars at the end of various lines.
I did that and I don't get any errors or warnings with checkpatch.pl --strict. It tells me:
------ $ ./scripts/checkpatch.pl --strict /tmp/0001-remove-unnecessary-logspam.patch total: 0 errors, 0 warnings, 65 lines checked
/tmp/0001-remove-unnecessary-logspam.patch has no obvious style problems and is ready for submission. ------
Here[1] you find our guidelines (which is a set of complementary rules to the guidelines you find in the kernel tree[2]).
Moreover, the subject must start with "batman-adv: ", because this patch will end up in the kernel and it requires this format to easily distinguish the subsystem that the patch is touching.
A couple of things to keep in mind while sending new versions of the same patch:
- don't reply to an existing thread
- write [PATCHvN] (with N = version of the patch - 2 in this case) in
the subject
OK, I can resubmit with the corrected subject line [PATCHv2] batman-adv: remove unnecessary logspam but I'd like to know first what this non-printable chars issue is about.
cheers, André