On Wed, May 29, 2013 at 08:20:15AM +0200, Martin Hundebøll wrote:
Hi Antonio,
Great work. We are looking forward to the next generation of Batman (shouldn't that be Robin?) :)
On 2013-05-29 00:20, Antonio Quartulli wrote:
Antonio Quartulli (10): batman-adv: make struct batadv_neigh_node algorithm agnostic batman-adv: make struct batadv_orig_node algorithm agnostic batman-adv: add bat_orig_print function API batman-adv: add bat_metric_get API function batman-adv: add bat_metric_is_similar API function batman-adv: add bat_metric_compare API function batman-adv: adapt bonding to use the new API functions batman-adv: adapt the gateway feature to use the new API functions batman-adv: adapt the neighbor purging routine to use the new API functions batman-adv: provide orig_node routing API
I see that in nc.c you changed the uses of neigh_node->tq_avg to the new private algo-specific struct (neigh_node->bat_iv.tq_avg), but there is no patch to make nc.c use the new API (bat_algo_ops.bat_metric_get() )...
Is this because you were in doubt wether NC will be usable with bat_v or just because you did "make && git-push" ? :)
because I am totally unaware on how this should work in a generic fashion :) maybe you can try to describe what is needed and then we try together to make the API comfortable for NC too.
Thanks!