The replies from gateway server to gateway client are usually sent via unicast packets. This only works when the destination address for the reply is already known to the translation table. But usually the gateway replies are in response to the first known contact from a device to the gateway server. So it can happen that the TT entry was not yet created.
The gateway server has therefore use broadcast as fallback when the entry is not yet known. This makes the first responses from a DHCP server to a DHCP client more robust.
Fixes: 2d5b555644b2 ("batman-adv: send every DHCP packet as bat-unicast") Signed-off-by: Sven Eckelmann sven@narfation.org --- net/batman-adv/soft-interface.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 216ac03..5829695 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -297,6 +297,18 @@ send: if (forw_mode == BATADV_FORW_SINGLE) do_bcast = false; } + + /* DHCP to from server to client should use unicast when TT + * entry is available and use broadcast as fallback + */ + if (!mcast_single_orig && dhcp_rcp == BATADV_DHCP_TO_CLIENT) { + mcast_single_orig = batadv_transtable_search(bat_priv, + NULL, + dst_hint, + vid); + if (!mcast_single_orig) + do_bcast = true; + } }
batadv_skb_set_priority(skb, 0);