Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Don't allow zero and multicast sender address

On Samstag, 6. August 2016 10:27:08 CEST Sven Eckelmann wrote: [...]

...

For data packets, I'm not quite sure, though. Could be interesting to not restrict that now to still allow enhancements regarding privacy, I think. And zero-source MAC addresses shouldn't harm anything in the case of data packets, should they?

So you would prefer here that is_broadcast_ether_addr is replaced for bcast and ucast packets with is_multicast_ether_addr? Same for patch 2, right?

Hm, no. This doesn't make any sense for patch 2 because patch 2 is about the destination and a destination with zero mac address isn't valid. Or do you see any reason to accept zero mac addresses as destination in the outer ethernet header?

Kind regards, Sven