Re: [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: split routing API data structure in subobjects

On Friday, May 06, 2016 02:46:40 Antonio Quartulli wrote:

•   .iface = {
  

•           .bat_activate = batadv_iv_iface_activate,
  

•           .bat_enable = batadv_iv_ogm_iface_enable,
  

•           .bat_disable = batadv_iv_ogm_iface_disable,
  

•           .bat_update_mac = batadv_iv_ogm_iface_update_mac,
  

•           .bat_primary_set = batadv_iv_ogm_primary_iface_set,
  

•   },
  

•   .neigh = {
  

•           .bat_cmp = batadv_iv_ogm_neigh_cmp,
  

•           .bat_is_similar_or_better = batadv_iv_ogm_neigh_is_sob,
  

•           .bat_print = batadv_iv_neigh_print,
  

•   },
  

•   .orig = {
  

•           .bat_print = batadv_iv_ogm_orig_print,
  

•           .bat_free = batadv_iv_ogm_orig_free,
  

•           .bat_add_if = batadv_iv_ogm_orig_add_if,
  

•           .bat_del_if = batadv_iv_ogm_orig_del_if,
  

•   },
  

If we are touching all API calls I suggest to remove the 'bat' prefix. For example:

.iface = { .activate = batadv_iv_iface_activate, .enable = batadv_iv_ogm_iface_enable, .disable = batadv_iv_ogm_iface_disable, .update_mac = batadv_iv_ogm_iface_update_mac, .primary_set = batadv_iv_ogm_primary_iface_set, },

Cheers, Marek