Re: [B.A.T.M.A.N.] [PATCH] staging: batman-adv: Use linux/etherdevice.h address helper functions

On Wednesday 03 November 2010 10:59:02 you wrote:

Replace custom ethernet address check functions by calls to the helpers in linux/etherdevice.h

Have you proven that the addresses are always two bytes aligned in memory? Afaik this function needs it.

In one case where the address was tested for broadcast and multicast address, the broadcast address check can be omitted as broadcast is also a multicast address.

We need to distinguish between these two types for different optimizations (research is currently done for multicast over mesh - but currently not part of batman-adv).

Best regards, Sven