Re: [B.A.T.M.A.N.] [PATCHv14 4/4] batman-adv: Add debugfs table for mcast flags

On T hursday, May 05, 2016 17:07:05 Linus Lüssing wrote:

•                   flags = orig_node->mcast_flags;
  

•                   if (!(orig_node->capabilities &
  

•                         BATADV_ORIG_CAPA_HAS_MCAST)) {
  

•                           seq_printf(seq, "%pM -\n", orig_node->orig);
  

•                           continue;
  

•                   }
  

•                   seq_printf(seq, "%pM [%c%c%c]\n", orig_node->orig,
  

•                              (flags &
  

BATADV_MCAST_WANT_ALL_UNSNOOPABLES ?

•                               'U' : '.'),
  

•                              (flags & BATADV_MCAST_WANT_ALL_IPV4 ?
  

•                               '4' : '.'),
  

•                              (flags & BATADV_MCAST_WANT_ALL_IPV6 ?
  

•                               '6' : '.'));
  

Little nitpick: Can you please move the flags assignment closer to where it is used.

Thanks! Marek