Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Add lower layer needed_(head|tail)room to own ones

On Friday, August 07, 2015 19:28:42 Sven Eckelmann wrote:

The maximum of hard_header_len and maximum of all needed_(head|tail)room of all slave interfaces of a batman-adv device must be used to define the batman-adv device needed_(head|tail)room. This is required to avoid too small buffer problems when these slave devices try to send the encapsulated packet in a tx path without the possibility to resize the skbuff.

Signed-off-by: Sven Eckelmann sven@narfation.org

v4:

• only check non-BATADV_IF_NOT_IN_USE interfaces
• drop the batadv_hardif_disable_interface changes which are already handled by the non-BATADV_IF_NOT_IN_USE check

v3:

• set hard_header_len always to ETH_HLEN and only modify needed_headroom as done in mac80211/vxlan
• do the same for needed_tailroom

v2:

• based on patch "batman-adv: don't access unregistered net_device object"
• remove the function call from batadv_update_min_mtu
• instead use batadv_hardif_disable_interface + batadv_hardif_enable_interface

---

net/batman-adv/hard-interface.c | 41 +++++++++++++++++++++++++++++++++++++++++ net/batman-adv/soft-interface.c | 2 -- 2 files changed, 41 insertions(+), 2 deletions(-)

Applied in revision e2b4301.

Thanks, Marek