Re: [B.A.T.M.A.N.] [PATCHv8 2/5] batman-adv: prevent duplication of ARP replies when DAT is used

On Donnerstag, 16. März 2017 14:34:26 CET Simon Wunderlich wrote:

•   /* If BLA is enabled, only forward ARP replies if we have claimed the
  

•    * source of the ARP reply or if no one else of the same backbone has
  

•    * already claimed that client. This prevents that different gateways
  

•    * to the same backbone all forward the ARP reply leading to multiple
  

•    * replies in the backbone.
  

•    */
  

•   if (!batadv_bla_is_my_claim(bat_priv, hw_src, vid)) {
  

•           batadv_dbg(BATADV_DBG_DAT, bat_priv,
  

•                      "Device %pM claimed by another backbone gw. Drop ARP reply.\n",
  

•                      hw_src);
  

•           dropped = true;
  

•           goto out;
  

•   }
  

Thanks for the rebasing. But there is no function "batadv_bla_is_my_claim". It was called batadv_bla_check_claim in patch 1.

And please also add a space between "PATCH" and "v8". This is how "git format-patch -v8" would have created it. And patchwork can handle it a little bit better when "PATCH" is a well separated word.

Kind regards, Sven